-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MkFit TrackCandidate error rescale + relaxed selection for overlap hits #37580
MkFit TrackCandidate error rescale + relaxed selection for overlap hits #37580
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37580/29336
|
A new Pull Request was created by @mmasciov (Mario Masciovecchio) for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters: |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e44227/23953/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
What sort of changes do you expect downstream from tracking due to this change? As I understand, this is expected to reduce fake tracks, so would the following increase if PFCandidates be expected? |
@jpata, both the changes in this PR contribute to a slight increase of (true) tracks in the pseudorapidity region around 2.5 (see below). So, a similarly slight increase of PF candidates in that region should be expected. Being "good" tracks, then this should be considered a slight positive change. In more detail:
|
type tracking |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
Update of mkFit JSON configurations following PR cms-sw/cmssw#37580
PR description:
This PR introduces two updates for mkFit tracking iterations:
(1) rescale covariance of TrackCandidate's before CMSSW final fit (where the rescaling option is configurable);
(2) relax selection of overlap hits.
It requires cms-data/RecoTracker-MkFit#9.
PR validation:
Rescaling the covariance of TrackCandidate's allows to better match CKF performance in terms of residuals, with a consequent decrease in duplicate tracks (from the duplicate merging/cleaning across mkFit and CKF iterations). E.g.:
http://uaf-10.t2.ucsd.edu/~mmasciov/MIC/rescaleError100/MTV_TTbarPU50_rescaleError100_defaultIters_mkFitOnly/plots_highPurity/effandfakePtEtaPhi.pdf
Similarly to CKF tracks, a few % bias in track pT is introduced, due to a known feature related the description of the detector material in endcaps. E.g.:
http://uaf-10.t2.ucsd.edu/~mmasciov/MIC/rescaleError100/MTV_TTbarPU50_rescaleError100_defaultIters_vsCKF/plots_highPurity/residualPt.pdf
Relaxing the selection of overlap hits allows to increase the track hit multiplicity, with a reduction of fake tracks:
http://uaf-10.t2.ucsd.edu/~mmasciov/MIC/rescaleError100/MTV_TTbarPU50_rescaleError100_extractedGeoms_overlapHitCuts_mkFitOnly/
For more details, please refer to presentations at TRK POG:
(1) https://indico.cern.ch/event/1133724/#4-mkfit-status-report
(2) https://indico.cern.ch/event/1142469/#5-mkfit-status-report
FYI @mmusich @vmariani