Add min pT filter in mkFit iterations during track building

[mmasciov]

PR description:

As per title, this PR adds configurable min pT filter in mkFit iterations during track building, aimed at addressing issue trackreco#83, relevant for HI tracking (following https://indico.cern.ch/event/1133724/#5-mkfit-usage-for-heavy-ion-tr).
Corresponding pp_on_XeXe_2017 and pp_on_AA modifiers with the same min pT cuts as CKF are also added.
Performance in default Run-3 configuration is unchanged (zero difference).

PR validation:

TTbar + PU: http://uaf-10.t2.ucsd.edu/~mmasciov/MIC/minPtCut/MTV_TTbarPU50_minPtIterConfig_forPR/
-> Zero difference is observed for standard pp tracking.

FYI @mmusich @vmariani

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37581/29337

• This PR adds an extra 60KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/MkFitCore/interface/IterationConfig.h modified in PR(s): MkFit TrackCandidate error rescale + relaxed selection for overlap hits #37580

[cmsbuild]

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for master.

It involves the following packages:

• RecoTracker/IterativeTracking (reconstruction)
• RecoTracker/MkFit (reconstruction)
• RecoTracker/MkFitCore (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[mmusich]

@mandrenguyen FYI

[slava77]

@cmsbuild please test

the previous seems to be stuck

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-143c5a/23965/summary.html
COMMIT: 6114caa
CMSSW: CMSSW_12_4_X_2022-04-15-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37581/23965/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593159
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3593129
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

so at the moment this is a no-op because the affected eras are not using mkFit:

cmssw/Configuration/Eras/python/Era_Run2_2018_pp_on_AA_cff.py

Line 9 in 9bd0dbd

Run2_2018_pp_on_AA = cms.ModifierChain(Run2_2018.copyAndExclude([trackingMkFitProd, trackdnn, trackingNoLoopers]), pp_on_AA, pp_on_AA_2018)

cmssw/Configuration/Eras/python/Era_Run3_pp_on_PbPb_cff.py

Line 9 in 9bd0dbd

Run3_pp_on_PbPb = cms.ModifierChain(Run3_noMkFit.copyAndExclude([trackdnn, trackdnn_CKF, trackingNoLoopers]), pp_on_AA, pp_on_PbPb_run3)

cmssw/Configuration/Eras/python/Era_Run2_2017_pp_on_XeXe_cff.py

Line 8 in 9bd0dbd

Run2_2017_pp_on_XeXe = cms.ModifierChain(Run2_2017.copyAndExclude([trackingMkFitProd,trackingNoLoopers]), pp_on_XeXe_2017)

but this move would allow the HIN folks to assess if they could move to mkFit for Run-3 already.
@cms-sw/reconstruction-l2 any objection in getting this integrated ASAP?

[mmusich]

type tracking

[clacaputo]

but this move would allow the HIN folks to assess if they could move to mkFit for Run-3 already. @cms-sw/reconstruction-l2 any objection in getting this integrated ASAP?

Hi @mmusich , no objection from our side

[clacaputo]

+reconstruction

• PR adds configurable min pT filter in mkFit iterations during track building, relevant for HI
• no reco changes are expected or observed in standard pp tracking
• effected HI Eras are not using mkFIt at the moment, but this PR will allow HIN to assess if they could move to mkFit for Run-3 already

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• It allows using mkfit also for HI reco (even if mkfit is not yet used for HI)