Fix CS8/EL8/CS9 openssl build error

[smuzaffar]

use OPENSSL_VERSION_NUMBER instead of OPENSSL_API_COMPAT

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37575/29327

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• Utilities/OpenSSL (core)

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test for el8_amd64_gcc10

[smuzaffar]

please test for cs9_amd64_gcc11

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c9447/23937/summary.html
COMMIT: f9e9674
CMSSW: CMSSW_12_4_X_2022-04-14-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37575/23937/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3593003
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c9447/23939/summary.html
COMMIT: f9e9674
CMSSW: CMSSW_12_4_X_2022-04-14-2300/cs9_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37575/23939/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 66034 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 423068
• DQMHistoTests: Total nulls: 281
• DQMHistoTests: Total successes: 3169668
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.6480000000000001 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.975 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 0.996 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 136.874 ): 0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 25202.0 ): -0.054 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 7.3 ): -0.269 KiB SiStrip/MechanicalView
• Checked 200 log files, 45 edm output root files, 48 DQM output files

[perrotta]

+1

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c9447/23938/summary.html
COMMIT: f9e9674
CMSSW: CMSSW_12_4_X_2022-04-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37575/23938/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 62754 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 412811
• DQMHistoTests: Total nulls: 311
• DQMHistoTests: Total successes: 3179895
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.31499999999999995 KiB( 47 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.063 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 11834.0 ): 2.372 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): 0.006 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): -0.117 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): -2.009 KiB SiStrip/MechanicalView
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: found differences in 13 / 47 workflows