-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unused step from mkFit special workflow #36477
Conversation
type bugfix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36477/27338
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages:
@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a47e13/21233/summary.html Comparison SummarySummary:
|
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 ping? |
urgent see #36504 and #36247 (comment) |
+Upgrade This PR is to remove an unused step in the mkFit workflow. No change is expected with this PR. PR test runs fine. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fixes bug from #36378 reported in #36347 (comment):
HARVESTFakeHLT
was added to the list of steps modified by the mkFit special workflow, but that workflow does not actually modify HARVEST steps.PR validation:
Reran matrix commands with reported error and observed that error was resolved.