handle FakeHLT steps in trackingOnly workflows

[kpedro88]

PR description:

Some time ago, the Run 2 upgrade workflows were changed to use a fake HLT menu. This created different steps, which were not handled by the trackingOnly special workflows. Now they are.

PR validation:

Checked output of runTheMatrix.py -nel 10024.1 --dryRun to see that RECO:reconstruction_trackingOnly etc. were in the cmsDriver commands as intended.

[kpedro88]

test parameters
workflows = 10024.1,11634.1

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36378/27157

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Add run3 tracking low pu era #33532

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

• Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @missirol, @slomeo, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a7c47/21029/summary.html
COMMIT: 4b1a0d9
CMSSW: CMSSW_12_2_X_2021-12-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36378/21029/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4a7c47/10024.1_TTbar_13+2017_trackingOnly+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-4a7c47/11634.1_TTbar_14TeV+2021_trackingOnly+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250608
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3250586
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[mmusich]

kindly pinging @cms-sw/pdmv-l2 @cms-sw/upgrade-l2

[kskovpen]

+1

[srimanob]

+Upgrade

This PR is to handle the fake HLT step in tracking-only workflow. The PR test on tracking-only workflow runs fine.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[fabiocos]

@qliphy @perrotta @kpedro88 This PR has apparently broken the toy:

17:54 cmsdev25 552> runTheMatrix.py --what upgrade -n
ignoring non-requested file relval_standard
ignoring non-requested file relval_highstats
ignoring non-requested file relval_pileup
ignoring non-requested file relval_generator
ignoring non-requested file relval_extendedgen
ignoring non-requested file relval_production
ignoring non-requested file relval_ged
processing relval_upgrade
ERROR reading file: relval_upgrade 'HARVESTFakeHLT_trackingMkFit_2017'
Traceback (most recent call last):
  File "/build/fabiocos/123X/CMSSW_12_3_X_2021-12-12-2300/bin/slc7_amd64_gcc900/runTheMatrix.py", line 598, in <module>
    ret = runSelected(opt)
  File "/build/fabiocos/123X/CMSSW_12_3_X_2021-12-12-2300/bin/slc7_amd64_gcc900/runTheMatrix.py", line 23, in runSelected
    mrd.prepare(opt.useInput, opt.refRel, opt.fromScratch)
  File "/build/fabiocos/123X/CMSSW_12_3_X_2021-12-12-2300/python/Configuration/PyReleaseValidation/MatrixReader.py", line 506, in prepare
    self.readMatrix(matrixFile, useInput, refRel, fromScratch)
  File "/build/fabiocos/123X/CMSSW_12_3_X_2021-12-12-2300/python/Configuration/PyReleaseValidation/MatrixReader.py", line 251, in readMatrix
    if self.relvalModule.steps[stepName] is None:
KeyError: 'HARVESTFakeHLT_trackingMkFit_2017'

Reverting it the problem disappears...

[mmusich]

@fabiocos already reported at #36347 (comment)