Phase II Patatrack Pixel Local Reco #36235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation plots/RelValTTbar_14TeV/CMSSW_12_1_0_pre5-PU_121X_mcRun3_2021_realistic_v15-v2/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_12_1_0_pre5-PU_121X_mcRun3_2021_realistic_v15-v1/GEN-SIM-DIGI-RAW
Validation plots (CPU vs GPU)/RelValTTbar_14TeV/CMSSW_12_1_0_pre5-PU_121X_mcRun3_2021_realistic_v15-v2/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_12_1_0_pre5-PU_121X_mcRun3_2021_realistic_v15-v1/GEN-SIM-DIGI-RAW
Throughput plots/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53
logs and
|
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36235/26865
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
cmsbuild
added
code-checks-rejected
code-checks-pending
and removed
code-checks-pending
code-checks-rejected
labels
|
@emiglior FYI |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36235/26866
|
|
A new Pull Request was created by @AdrianoDee for master. It involves the following packages:
@malbouis, @civanch, @yuanchao, @makortel, @cvuosalo, @fwyzard, @ianna, @mdhildreth, @cmsbuild, @Dr15Jones, @slava77, @jpata, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@srimanob FYI. Would be eventually nice to have some wf to test phase-2 GPU reconstruction. |
|
@cmsbuild please test |
@AdrianoDee shouldnt |
|
@cmsbuild please abort |
|
enable gpu |
|
@cmsbuild please test |
|
+Upgrade |
|
+1 |
makortel
reviewed
Dec 28, 2021
|
|
||
| auto const& input = iEvent.get(pixelDigiToken_); | ||
|
|
||
| const TrackerGeometry* geom_ = &iSetup.getData(geomToken_); |
There was a problem hiding this comment.
The esConsumes() is missing for geomToken_ and that is causing workflow 39434.502 step 3 to fail on a machine with a GPU (see #36604).
8 tasks
|
+1 |
cmsbuild
added
reconstruction-approved
tests-started
tracking
trk
and removed
reconstruction-pending
tests-approved
labels
|
-1 Failed Tests: RelVals RelValsValueError: Undefined workflows: 39434.5, 39434.501, 39434.502 GPU Comparison SummarySummary:
|
|
+heterogeneous |
cmsbuild
added
fully-signed
pdmv-approved
heterogeneous-approved
and removed
pending-signatures
pdmv-pending
heterogeneous-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). |
|
cms-bot internal usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Allowing Patatrack tracker local reco to run on Phase2 tracker. A summary:
maxNumModulesto 4000 to allow for Phase2 tracker geometry to be accommodated;maxNumDigis(set based on ttbar events @ =200);28forTrackingRecHit2DSOAView:: PhiBinner. This in principle could be templated but seems to me it would mess up with too many specialized definitions.m_nMaxModules(and it's getternMaxModules()forTrackingRecHit2DSOAViewandTrackingRecHit2DHeterogeneousto determine hits module structures sizes; added in the constructor forTrackingRecHit2DHeterogeneous.phase1PixelTopologytopixelTopologyand separating the two topologies in two namespaces (namelyphase1PixelTopologyandphase2PixelTopology);SiPixelRawToClusterCUDAin two branches to account for digis already being there for Phase2;gpuCalibPixelpixelCPEforGPU::CommonParamsto includemaxModuleStrideandnumberOfLaddersInBarrelto have them propagated around being different for Phase1 and Phase2;pixelCPEforGPU::DetParamsto includenRowsRoc,nColsRoc,nRows,nColsandnumPixsInModulebeing not constant among modules for Phase2;isUpgrade_flag or template all around;PR validation:
Attaching in the first comment a validation run via cms-patatrack/patatrack-validation on a P100 at T2@Bari.
Local tracker validation for Run3 samples (comparison
12_2_0_pre2vs this PR for CPU/GPU):Local tracker validation for Phase2 samples (comparison legacy reco from
12_2_0_pre2vs this PR for CPU/GPU):A simple customization function to run the new local reco on top of a generic wf here. This may be tested, e.g., on top of
38634.1workflow (onstep3).This will conflict with #36215 and #36176. As soon as those are merged a fix will be committed here. In a following PR the modifications to Pixel Tracks reco will be addressed.
cc: @mtosi @vmariani @mmusich @VinInn
(probably you will be notified anyway)