-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GPU workflows #35331
Update GPU workflows #35331
Conversation
When the gpu modifier is enabled, make the Pixel, ECAL and HCAL reconstruction offloadable to a GPU.
Simplify the Pixel local reconstruction running on GPU, taking advatage of cms-sw#34259.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35331/25377
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
@cmsbuild, @jordan-martins, @bbilin, @wajidalikhan, @Martin-Grunewald, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
# there is no customisation for enabling the Patatrack pixel quadruplets running only on the CPU | ||
}, | ||
reco = { | ||
# skip the @pixelTrackingOnlyValidation which cannot run together with the full reconstruction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sroychow @arossi83 @tsusa @connorpa please take note of this issue triggered in the phase1 pixel validation code when using the pixelonly reconstruction (by the way if the issue is only in SiPixelPhase1HitsV
I suppose one could cook temporarily a lighter ad hoc validation sequence, just removing that module).
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-335860/18730/summary.html Comparison SummarySummary:
|
+1 |
+Upgrade This PR introduces new GPU workflows as the title said. |
@cms-sw/pdmv-l2 Any comment? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Add new GPU workflows, that run the Patatrack pixel local and pixel-only track reconstruction in addition to the full reconstruction, with the possibility of offloading to GPUs also the ECAL and HCAL local reconstruction.
PR validation:
Validated with
Note: this PR includes the changes from #34978; it can be rebased once that is merged.