-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUDAService verbosity #35117
CUDAService verbosity #35117
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35117/25012
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
39f0e40
to
0147cfe
Compare
please test |
0147cfe
to
421f61f
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35117/25018
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
@perrotta, @makortel, @Martin-Grunewald, @fwyzard, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
421f61f
to
c31541a
Compare
Finally everything looks good:
|
+heterogeneous |
+1 |
The current implementation should be fine by itself.
|
please test
|
Once #35298 is merged, we can remove
from |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39073b/18741/summary.html GPU Comparison SummarySummary:
Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Add the NVIDIA driver, CUDA driver and runtime library versions to the
CUDAService
message.Make the
CUDAService
less verbose by default, with an option to display the full messages, and enable it in theMessageLogger
by default.PR validation:
The default, compact message on a machine with two GPUs now looks like
The full, verbose message on the same machine now looks like