cleanup HLTHcalCalibTypeFilter #35315

fwyzard · 2021-09-17T09:17:56Z

Remove unused variables, and merge the header file into the implementation.

fwyzard · 2021-09-17T09:18:04Z

please test

cmsbuild · 2021-09-17T09:26:46Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35315/25352

ERROR: Build errors found during clang-tidy run.

HLTrigger/special/plugins/HLTHcalCalibTypeFilter.cc:90:40: error: member reference type 'const FEDRawDataCollection' is not a pointer; did you mean to use '.'? [clang-diagnostic-error]
    const FEDRawData& fedData = rawdata->FEDData(fed);
                                       ^~
                                       .
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

fwyzard · 2021-09-17T09:39:51Z

please test

cmsbuild · 2021-09-17T09:47:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35315/25354

This PR adds an extra 16KB to repository

cmsbuild · 2021-09-17T09:48:12Z

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HLTrigger/special (hlt)

@Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-09-17T11:04:34Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb3dc8/18698/summary.html
COMMIT: 0f69a4e
CMSSW: CMSSW_12_1_X_2021-09-16-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35315/18698/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

11634.0

----- Begin Fatal Exception 17-Sep-2021 12:29:11 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=HLTHcalCalibTypeFilter label='hltHcalCalibTypeFilter'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'FilterSummary'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

12434.0

----- Begin Fatal Exception 17-Sep-2021 12:29:49 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=HLTHcalCalibTypeFilter label='hltHcalCalibTypeFilter'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'FilterSummary'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

11634.911

----- Begin Fatal Exception 17-Sep-2021 12:30:06 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=HLTHcalCalibTypeFilter label='hltHcalCalibTypeFilter'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'FilterSummary'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

11634.912

RelVals-INPUT

158.1158.1_QCD_Pt_80_120_13_HI+QCD_Pt_80_120_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_QCD_Pt_80_120_13_HI+QCD_Pt_80_120_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO.log
158.2158.2_PhotonJets_Pt_10_13_HI+PhotonJets_Pt_10_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_PhotonJets_Pt_10_13_HI+PhotonJets_Pt_10_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO.log
158.3158.3_ZEEMM_13_HI+ZEEMM_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_ZEEMM_13_HI+ZEEMM_13_HIINPUT+DIGIHI2018PPRECO+RECOHI2018PPRECO+HARVESTHI2018PPRECO.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 17-Sep-2021 12:12:36 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=HLTHcalCalibTypeFilter label='hltHcalCalibTypeFilter'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'FilterSummary'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 17-Sep-2021 12:14:01 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=HLTHcalCalibTypeFilter label='hltHcalCalibTypeFilter'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'FilterSummary'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 17-Sep-2021 12:12:30 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=HLTHcalCalibTypeFilter label='hltHcalCalibTypeFilter'
Exception Message:
Illegal parameter found in configuration.  The parameter is named:
 'FilterSummary'
You could be trying to use a parameter name that is not
allowed for this plugin or it could be misspelled.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

Martin-Grunewald · 2021-09-17T12:12:59Z

It seems you need to code a customisation function in customiseHLTforCMSSW which deletes the removed parameter(s) in all instances of the plugin where they are still present. (if hasattr... delattr)

fwyzard · 2021-09-17T12:23:48Z

Yeah... will do.

fwyzard · 2021-09-19T09:45:29Z

please test

cmsbuild · 2021-09-19T09:53:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35315/25379

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): Add support for the gpu modifier at HLT #34978, Add GEM unpacker in L1Repack FullMC and temporary load of GEM geometry to hltGetConfiguration #34788, Move MSLayerKeeper* objects from thread-local into EventSetup #35269, [EGM] Eta-Extended-Electrons (EEE) #35309, Update GPU workflows #35331

cmsbuild · 2021-09-19T09:53:42Z

Pull request #35315 was updated. @Martin-Grunewald can you please check and sign again.

cmsbuild · 2021-09-19T15:35:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb3dc8/18736/summary.html
COMMIT: 1e2b058
CMSSW: CMSSW_12_1_X_2021-09-19-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35315/18736/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 3211080
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3211058
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

Martin-Grunewald · 2021-09-20T04:48:07Z

+1

cmsbuild · 2021-09-20T04:48:32Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-09-20T06:23:40Z

+1

cmsbuild added this to the CMSSW_12_1_X milestone Sep 17, 2021

cmsbuild added code-checks-pending hlt-pending orp-pending pending-signatures tests-started labels Sep 17, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 17, 2021

fwyzard force-pushed the HLTHcalCalibTypeFilter_cleanup branch from 5707091 to 0f69a4e Compare September 17, 2021 09:39

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 17, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 17, 2021

cmsbuild added tests-rejected and removed tests-started labels Sep 17, 2021

fwyzard added 3 commits September 19, 2021 11:44

Remove unused variables in HLTHcalCalibTypeFilter

d4a160d

Merge header file and implementation of HLTHcalCalibTypeFilter

f129999

Update the HLT configuration for the changes to HLTHcalCalibTypeFilter

1e2b058

fwyzard force-pushed the HLTHcalCalibTypeFilter_cleanup branch from 0f69a4e to 1e2b058 Compare September 19, 2021 09:45

cmsbuild removed tests-rejected code-checks-approved labels Sep 19, 2021

cmsbuild added code-checks-pending tests-started labels Sep 19, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 19, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 19, 2021

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Sep 20, 2021

cmsbuild added orp-approved and removed orp-pending labels Sep 20, 2021

cmsbuild merged commit 8cb2dd1 into cms-sw:master Sep 20, 2021

makortel mentioned this pull request Sep 20, 2021

Move MSLayerKeeper* objects from thread-local into EventSetup #35269

Merged

cmsbuild mentioned this pull request Sep 20, 2021

CT-PPS: Association cut update #35248

Merged

fwyzard deleted the HLTHcalCalibTypeFilter_cleanup branch July 31, 2022 13:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cleanup HLTHcalCalibTypeFilter #35315

cleanup HLTHcalCalibTypeFilter #35315

fwyzard commented Sep 17, 2021

fwyzard commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

fwyzard commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

Martin-Grunewald commented Sep 17, 2021

fwyzard commented Sep 17, 2021 via email

fwyzard commented Sep 19, 2021

cmsbuild commented Sep 19, 2021

cmsbuild commented Sep 19, 2021

cmsbuild commented Sep 19, 2021

Martin-Grunewald commented Sep 20, 2021

cmsbuild commented Sep 20, 2021

perrotta commented Sep 20, 2021

cleanup HLTHcalCalibTypeFilter #35315

cleanup HLTHcalCalibTypeFilter #35315

Conversation

fwyzard commented Sep 17, 2021

fwyzard commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

fwyzard commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

cmsbuild commented Sep 17, 2021

RelVals

RelVals-INPUT

AddOn Tests

Martin-Grunewald commented Sep 17, 2021

fwyzard commented Sep 17, 2021 via email

fwyzard commented Sep 19, 2021

cmsbuild commented Sep 19, 2021

cmsbuild commented Sep 19, 2021

cmsbuild commented Sep 19, 2021

Comparison Summary

Martin-Grunewald commented Sep 20, 2021

cmsbuild commented Sep 20, 2021

perrotta commented Sep 20, 2021