Set numberOfConcurrentLuminosityBlocks to 1 for ALCA sequences that have EDModules that are not planned to support concurrent lumis #35073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave EDModules that are not going to support concurrent lumis
This was referenced Aug 30, 2021
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35073/24956
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@perrotta, @malbouis, @yuanchao, @davidlange6, @cmsbuild, @tlampen, @qliphy, @pohsun, @francescobrivio, @fabiocos, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable threading |
|
@cmsbuild, please test workflow 134.0,1001.0,1001.2,1004.0,1030.0 |
|
-1 Failed Tests: RelVals-THREADING RelVals-THREADING
Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
|
Interesting. The crash is in thread 8 |
|
I should add that this PR should not affect 11634.911. |
|
test parameters:
|
|
@cmsbuild, please test |
|
The crash is related to https://gitlab.com/hepcedar/lhapdf/-/issues/2 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-886b44/18148/summary.html Comparison SummarySummary:
|
|
+alca |
|
+1 |
cmsbuild
added
fully-signed
operations-approved
orp-approved
and removed
operations-pending
pending-signatures
orp-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
Moving our discussion to #35082 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
As reported in #25090 the EDModules
AlcaBeamSpotProducer,AlignmentProducerAsAnalyzer,MillePedeFileConverter,AlcaBeamSpotProducerdo not support concurrent lumis, and in the PPD workshop in March it was said that in T0 the ALCA steps will process only one lumi at a time and therefore they would not benefit from concurrent lumis.In order to silence the warning message on multithreaded jobs, and to later allow changing that warning to an exception (to better prevent any modules that do not support concurrent lumis to creep in workflow steps that are expected to support concurrent lumis), this PR suggest the
ConfigBuilderto set the number of concurrent lumis (and IOVs) explicitly to 1 if the job hasALCAstep with any of the AlCa sequences that (currently) contain modules that do not support concurrent lumis. In this PR theConfiguration/AlCa/python/autoAlca.pywas chosen as a place for the list of those sequences, in principle they could be listed elsewhere as well.To best of my knowledge this approach should cover both
cmsDriverand T0, since the latter usesConfigBuildere.g. incmssw/Configuration/DataProcessing/python/Reco.py
Line 240 in 209b393
PR validation:
Workflows
134.0,1001.0,1001.2,1004.0,1030.0set theirALCAorALCAOUTPUTsteps to use