Remove logic for setting nConcurrentLumis from cmsDriver in favor of similar logic now in cmsRun #35302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35302/25312
|
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@perrotta, @cmsbuild, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters:
|
|
@cmsbuild, please test |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
cmsbuild
added
fully-signed
operations-approved
orp-approved
and removed
operations-pending
pending-signatures
orp-pending
labels
makortel
added a commit
to makortel/cmssw
that referenced
this pull request
Mar 30, 2022
I was supposed to do this at the same time as cms-sw#35302 that followed cms-sw#34231 and the conclusion in cms-sw#33436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR suggests to remove the logic to set
nConcurrentLumisbased onnStreamsthat was introduced in #32406 in favor of similar logic introduced in cmsRun in #34231.Resolves cms-sw/framework-team#260
PR validation:
Inspected the configurations for the matrix workflows
limited,5.2,140.0,521.0,7.0,300.0,140.0,5.5,511.0,281.0,8.1,534.0,281.0,132.0,280.0,120.0and only the GEN steps specified in #35182 and in ALCA step in 1001.0 (#35073) set theprocess.options.numberOfConcurrentLumis = 1. All other steps use the default value of0, which the cmsRun then interprets as "set default value based on the number of streams".