LHAPDF::_getQ2CachesMap() is not thread safe #35082
Comments
|
assign core, generators |
|
New categories assigned: core,generators @Dr15Jones,@smuzaffar,@Saptaparna,@mkirsano,@SiewYan,@alberto-sanchez,@makortel,@agrohsje,@GurpreetSinghChahal you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
A new Issue was created by @makortel Matti Kortelainen. @Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
|
Do we want to try patch https://gitlab.com/hepcedar/lhapdf/-/merge_requests/3 ? I'm not really sure how we could test it conclusively, given that it took ~1.5 months to hit to the issue after the update to LHAPDF 6.3.0. |
|
Hello, does it mean to put lhapdf code to our repo?
If it is needed for CMS and it will work, why not.
Then probably we have to write to authors about it.
…On 9/7/21 5:12 PM, agrohsje wrote:
Hi @mkirsano <https://github.com/mkirsano> : I would agree with
@makortel <https://github.com/makortel> and apply the proposed patch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35082 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGOJUVCW4SNU34FS3E2PALUAYTWPANCNFSM5DDBTJNA>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Apparently the authors released a beta of 6.4.0 that eliminates the cache (I did not look into details), see https://gitlab.com/hepcedar/lhapdf/-/issues/2#note_674891431. Should we try that? |
|
If #35251 is connected, we just got a way to test rather conclusively if the beta 6.4.0 would fix the race conditions in our case. |
|
It happened here as well |
|
Yes, OK |
|
Given that we have updated LHAPDF to 6.4.0 that (presumably) eliminated the cache, and that we don't have any reports from past few years (although that doesn't mean they couldn't have occurred), maybe we should close this issue? |
|
cms-bot internal usage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#35073 (comment) experienced a rare crash
that points to a race condition in LHAPDF that is discussed in https://gitlab.com/hepcedar/lhapdf/-/issues/2.
The text was updated successfully, but these errors were encountered: