-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume records for mustache SC only if the mustache algo is used - 112x backport #33100
Consume records for mustache SC only if the mustache algo is used - 112x backport #33100
Conversation
…C algo is configured to use them.
A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_11_2_X. It involves the following packages: RecoEcal/EgammaClusterAlgos @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #32997 |
@thomreis |
No I do not expect this to be needed in an upcoming MWGR. It would rather be for MC productions where the mustache algorithm does not run and we do not have the parameters in the GT. I do not know if this situation will happen though. |
Thank you for clarifying. I'm not aware of existing problem in production. It sounds like this is a "nice to have" (not a required feature). |
@cmsbuild please test |
Yes, this is not something that needs to be added urgently. But it completes the changes in PR #32066 could save us from some potential head scratching in the future. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-833b34/13336/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Use the records for EcalMustacheSCParameters and EcalSCDynamicDPhiParameters only if the SC algorithm is configured to run the mustache and/or the dynamic dPhi. This should avoid exceptions if the records are not in the GT. No changes to the outputs are expected.
The ESProducers for the records are still kept in the default configuration since not all necessary GTs contain the records already.
Backport to 112x since the new records are also consumed in the 11_2_X release.
PR validation:
Passes limited matrix tests.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backport of #32997