ECAL SC parameters to EventSetup

[thomreis]

PR description:

This PR moves the up to now hard coded ECAL mustache SC parameters and dynamic dPhi parameters to the EvetnSetup so that they can be taken from the GT in the future. A separate condFormat is defined for both sets of parameters and two helper classes are used to access the data within the SC code. Since the new records are not yet in the DB they are provided with an ESSource and ESProducer.
Data maker modules to generate sqlite files are included.
The initial parameters in this PR are the same as the ones currently in the master branch, introduced with #31823 , and so no changes are expected in the output.

PR validation:

• All runTheMatrix.py -l limited -i all --ibeos tests passed
• Perfect agreement between SCs reconstructed with CMSSW_11_2_0_pre7 with Updated parameters of the Mustache SC algorithm, optimized for Run 3 #31823 parameters and this code on top of CMSSW_11_2_0_pre7 (RelValH125GG sample, 2500 events). SC energy (green: reference, red: this PR, blue: different parameter set)

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32066/19683

• This PR adds an extra 168KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondFormats/EcalObjects/src/classes.h modified in PR(s): Ecal phase2 new digitization 11 2 x #31726
  • File CondFormats/EcalObjects/src/classes_def.xml modified in PR(s): Ecal phase2 new digitization 11 2 x #31726

[slava77]

Since the new records are not yet in the DB they are provided with an ESSource and ESProducer.
Data maker modules to generate sqlite files are included.

why not use a DBsource with a toGet pointing to an sqlfile?

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

CondCore/EcalPlugins
CondFormats/DataRecord
CondFormats/EcalObjects
CondTools/Ecal
HLTrigger/Configuration
RecoEcal/EgammaClusterAlgos
RecoEcal/EgammaClusterProducers
RecoEcal/EgammaCoreTools
RecoParticleFlow/PFProducer

@perrotta, @cmsbuild, @yuanchao, @slava77, @christopheralanwest, @tocheng, @Martin-Grunewald, @jpata, @tlampen, @ggovi, @fwyzard, @pohsun can you please review it and eventually sign? Thanks.
@mmarionncern, @Sam-Harper, @rchatter, @jainshilpi, @afiqaize, @tocheng, @lgray, @Martin-Grunewald, @makortel, @sobhatta, @rovere, @lecriste, @hatakeyamak, @mmusich, @argiro, @varuns23, @seemasharmafnal, @cbernet this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jpata]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-09-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10592/console Started: 2020/11/09 17:14

[ggovi]

+1

[thomreis]

@christopheralanwest, @ggovi can you please sign again after the rebase?

[thomreis]

Crossed mid air. :-)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-29930b/11029/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 2274 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2963516
• DQMHistoTests: Total failures: 54292
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2909202
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 158 log files, 34 edm output root files, 37 DQM output files

[jpata]

hmm, there's a lot of changes, but only in the workflow 11642.911, which seems to be for DD4HEP. However, I can't see any such PR in the bot report: #32066 (comment). Any ideas?

[mmusich]

Any ideas?

#32283

[jpata]

ah, thank you, it was not on my radar.

[jpata]

+reconstruction

• migrates ECAL Mustache supercluster parameters to the EventSetup by creating new CondFormats for EcalMustacheSCParameters and EcalSCDynamicDPhiParameters
• the new conditions are provided currently by ESSource & ESProducer (not yet in global tag)
• tests show many differences, but they are unrelated/fake per Fake differences in wf 11642.911 #32283

[thomreis]

Links to plots in the comparison seem broken.

[christopheralanwest]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1