-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume records for mustache SC only if the mustache algo is used #32997
Consume records for mustache SC only if the mustache algo is used #32997
Conversation
…C algo is configured to use them.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32997/21266
|
A new Pull Request was created by @thomreis (Thomas Reis) for master. It involves the following packages: RecoEcal/EgammaClusterAlgos @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2005c5/13093/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Use the records for EcalMustacheSCParameters and EcalSCDynamicDPhiParameters only if the SC algorithm is configured to run the mustache and/or the dynamic dPhi. This should avoid exceptions if the records are not in the GT. No changes to the outputs are expected.
The ESProducers for the records are still kept in the default configuration since not all necessary GTs contain the records already.
PR validation:
Passes limited matrix tests.
Removes the NoRecord exception if the ESProducers for the records are commented out in the configuration manually and the box SC algorithm is used without dynamic dPhi (Tested by manually changing WF 5.1 configuration).
None of the limited matrix WFs seems to use the box algo though and no difference is observed in the matrix test results when the ESProducers are removed.