-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to take DCS Status from software FED, when SCAL is not available #29198
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29198/14183
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CalibTracker/SiStripCommon @pgunnell, @chayanit, @zhenhu, @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The simulation workflows are not being treated correctly. I'll fix in the next commit. |
test parameters |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In case the DCS status from SCAL is not available, fall back to
DCSRecord
data provided by the software FED n. 1022. The logic is modified in two classes:SiStripDCSStatus
andDetStatus
.Both classes are used to select events in different ALCARECO workflows, while
SiStripDCSStatus
is also used to filter events in several Tracker and Tracking DQM modules.
No differences are expected in Run1 and Run2 workflows. For Run3 data the ALCARECO selectors now work correctly.
PR validation:
Tested with
runTheMatrix.py -l 1001.0,138.1
and checked that in runs with SCAL there are no differences, while with recent MWGR 2020 cosmic data the events are filtered correctly.if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport, but a backport will be proposed in 11.0.X to be used for the next MWGR.