Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration to DCSRecord of GenericTriggerEventFlag #37084

Merged
merged 2 commits into from
Mar 3, 2022
Merged

migration to DCSRecord of GenericTriggerEventFlag #37084

merged 2 commits into from
Mar 3, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 28, 2022

PR description:

In the same spirit of #29198 and #35782, in case the DCS status from SCAL is not available, fall back to DCSRecord data provided by the software FED n. 1022. The logic is modified in the class GenericTriggerEventFlag which is used in several DQM clients.
No differences are expected in Run1 and Run2 workflows. For Run3 data the selector should now work correctly.

PR validation:

Run successfully runTheMatrix.py -l imited --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild cmsbuild added this to the CMSSW_12_3_X milestone Feb 28, 2022
@cmsbuild cmsbuild mentioned this pull request Feb 28, 2022
Merged
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37084/28566

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CommonTools/TriggerUtils (hlt, l1)
  • DQM/HLTEvF (dqm, hlt)
  • DQM/SiPixelPhase1Common (dqm)
  • DQM/SiStripMonitorClient (dqm)
  • DQM/SiStripMonitorCluster (dqm)
  • DQM/TrackingMonitorSource (dqm)
  • DQMOffline/JetMET (dqm)
  • DQMOffline/Trigger (dqm)

@Martin-Grunewald, @rekovic, @epalencia, @emanueleusai, @ahmad3213, @cmsbuild, @missirol, @jfernan2, @pmandrik, @cecilecaillol, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio, @schoef, @fioriNTU, @ahinzmann, @threus, @cericeci, @venturia, @mmarionncern, @hdelanno, @jdolen, @silviodonato, @JanFSchulte, @jhgoh, @missirol, @sscruz, @seemasharmafnal, @trocino, @rociovilar, @sroychow, @VinInn, @jdamgov, @nhanvtran, @gkasieczka, @jandrea, @idebruyn, @mmusich, @mtosi, @arossi83, @HuguesBrun, @Fedespring, @calderona, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc14ca/22706/summary.html
COMMIT: 268ae0f
CMSSW: CMSSW_12_3_X_2022-02-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37084/22706/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 28 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 4001183
  • DQMHistoTests: Total failures: 62170
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3938991
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -330.984 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): -27.582 KiB PixelPhase1/Tracks
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

@mmusich many plots in Tracking folder that were previously filled, now get zero entries:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_3_X_2022-02-27-2300+fc14ca/48603/dqm-histo-comparison-summary.html
The same happens for plots in HLT folder

@mmusich mmusich force-pushed the migrateGenericTriggerEventFlag branch from 268ae0f to df88baa Compare February 28, 2022 18:21
@mmusich
Copy link
Contributor Author

mmusich commented Feb 28, 2022

@jfernan2

many plots in Tracking folder that were previously filled, now get zero entries:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_3_X_2022-02-27-2300+fc14ca/48603/dqm-histo-comparison-summary.html
The same happens for plots in HLT folder

yes, I think the MC case was not handled correctly. Let's see if the last push resolved.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37084/28580

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@mmusich mmusich force-pushed the migrateGenericTriggerEventFlag branch from df88baa to 2046708 Compare February 28, 2022 18:34
@jfernan2
Copy link
Contributor

jfernan2 commented Mar 2, 2022

Many MEs (about 2300) are removed now and other 100s get fewer entries. I am not sure if this is due to last commits or to the interference of external commits

@mmusich
Copy link
Contributor Author

mmusich commented Mar 2, 2022

I am not sure if this is due to last commits or to the interference of external commits

#37090 this might play a large role here...

@jfernan2
Copy link
Contributor

jfernan2 commented Mar 2, 2022

Yes, indeed the changes from #37090 are the same. Thanks

@jfernan2
Copy link
Contributor

jfernan2 commented Mar 2, 2022

+1

@missirol
Copy link
Contributor

missirol commented Mar 2, 2022

Thanks for this update, @mmusich .

As a side note to DQM, I noticed a DQM/TrackerCommon/interface/TriggerHelper.h, which looks somewhat similar to GenericTriggerEventFlag; DQM might want to update it like in this PR, or remove it if it is not used.

@missirol
Copy link
Contributor

missirol commented Mar 2, 2022

+hlt

@epalencia
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Mar 3, 2022

+1

@cmsbuild cmsbuild merged commit 4456728 into cms-sw:master Mar 3, 2022
@jfernan2
Copy link
Contributor

jfernan2 commented Mar 3, 2022

Thanks for this update, @mmusich .

As a side note to DQM, I noticed a DQM/TrackerCommon/interface/TriggerHelper.h, which looks somewhat similar to GenericTriggerEventFlag; DQM might want to update it like in this PR, or remove it if it is not used.

Thanks @missirol
It seems to me TriggerHelper is not being used[1] but it would be nice to have a confirmation from @mmusich

[1] https://github.com/cms-sw/cmssw/search?q=TriggerHelper

@mmusich
Copy link
Contributor Author

mmusich commented Mar 3, 2022 •
edited
Loading

It seems to me TriggerHelper is not being used[1] but it would be nice to have a confirmation from @mmusich

seems indeed unused in cmssw and judging by the content and the fact that shares the same original author of GenericTriggerEventFlag it might have been an early prototype used internally for Tracker and then moved to a more central package for centralized usage.
I cannot exclude is used somewhere in some calibration / commissionig chain set up a long time ago, so I'll just migrate that one as well for good measure.

@mmusich mmusich mentioned this pull request Mar 3, 2022
Merged
This was referenced Mar 3, 2022
Merged
Merged
Open
@mmusich mmusich deleted the migrateGenericTriggerEventFlag branch March 3, 2022 18:04
@francescobrivio francescobrivio mentioned this pull request Mar 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@missirol missirol missirol left review comments

Assignees
No one assigned
Labels
code-checks-approved dqm-approved fully-signed hlt-approved l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_3_X
Development

Successfully merging this pull request may close these issues.
7 participants
@mmusich @cmsbuild @Martin-Grunewald @jfernan2 @missirol @epalencia @qliphy