-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix SiPixelCalCosmics
for Run3: logical mistake in DetStatus [12_0_X]
#35379
fix SiPixelCalCosmics
for Run3: logical mistake in DetStatus [12_0_X]
#35379
Conversation
type bug-fix |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X. It involves the following packages:
@malbouis, @yuanchao, @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @kskovpen, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
urgent (it would be good to have for the next cosmics data-taking period) |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56b0f5/18855/summary.html Comparison SummarySummary:
|
+alca |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #35371
PR description:
It has been found out that the
SiPixelCalCosmics
ALCARECO produced exactly zero events for the full CRUZET link to DAS.The issue has been traced to the logical mistake when migrating the
DPGAnalysis/Skims/src/DetStatus.cc
class to not use theDCSStatus
from scalers, but fromDCSRecord
from the software FED#1022
to extractDCSRecord
(see PR #29198).From Run3 we won't have scalers, so the new path in the code started to be exercised only during CRUZET'21.
Since the final boolean
accept
was initialized tofalse
the final result of the filter was alwaysfalse
leading to no events saved.PR validation:
Tested succesfully the following
cmsDriver
command:which was giving 0 events before and gives now:
I profit of this PR to change the
AndOr
in the configuration to take theOR
of the BPIx and FPix DCS bits, instead of the AND after consultation with the pixel offline group.if this PR is a backport please specify the original PR and why you need to backport that PR:
This is combined backport of #35371 and #35378