Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_2_X] MXNet-based implementation of the ParticleNet tagger #29063

Merged
merged 5 commits into from
Apr 16, 2020

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Feb 29, 2020

Backport of #28902.
For analysis of the full Run2 data and NanoAOD production.

Needs:

We should also integrate cms-data/RecoBTag-Combined#24 together with the update to MXNet 1.5.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hqucms (Huilin Qu) for CMSSW_10_2_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTag/Configuration
RecoBTag/FeatureTools
RecoBTag/MXNet

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

@hqucms could you explain in the PR description why you need this backport?

@hqucms
Copy link
Contributor Author

hqucms commented Mar 3, 2020

@silviodonato We would like to have this for analysis of the full Run2 data and NanoAOD production. I updated the PR description with that.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2020

Pull request #29063 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

@silviodonato
Copy link
Contributor

@hqucms could you confirm the last two commits make this PR identical to #28902 ?

@silviodonato
Copy link
Contributor

please test with cms-sw/cmsdist#5591

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 10, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5591
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5106/console Started: 2020/03/10 16:13

@hqucms
Copy link
Contributor Author

hqucms commented Mar 10, 2020

@hqucms could you confirm the last two commits make this PR identical to #28902 ?

@silviodonato Yes -- this backport is identical as #28902 except that the tagger is not enabled in the MiniAOD step to preserve the event content.

@cmsbuild
Copy link
Contributor

+1
Tested at: 5fe1910
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c57c4/5106/summary.html
CMSSW: CMSSW_10_2_X_2020-03-10-1100
SCRAM_ARCH: slc6_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c57c4/5106/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007491
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007300
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@slava77
Copy link
Contributor

slava77 commented Mar 23, 2020

@cmsbuild please test

to refresh the comparisons

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

Pull request #29063 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

Pull request #29063 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

@hqucms
Copy link
Contributor Author

hqucms commented Apr 8, 2020

@slava77 Done in fcc6974 and 0beb8ab.

@slava77
Copy link
Contributor

slava77 commented Apr 8, 2020

@cmsbuild please test

this will just check that the "production" workflows are not broken; I'll re-check locally for the test with _devel enabled

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5719
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5607/console Started: 2020/04/08 19:38

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

+1
Tested at: 0beb8ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-beec7a/5607/summary.html
CMSSW: CMSSW_10_2_X_2020-04-08-1100
SCRAM_ARCH: slc6_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-beec7a/5607/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007544
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007352
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@santocch
Copy link

+1

@slava77
Copy link
Contributor

slava77 commented Apr 14, 2020

+1

for #29063 0beb8ab

  • code changes are in line with the PR description and the follow up review. The backport is consistent with the master version, ignoring some parts that do not apply for the backport (e.g. BoostedJetMXNetJetTagsProducer.cc fillDescriptions and the coupled pfParticleNet_cff.py)
  • jenkins tests pass and comparisons with the baseline show no differences (by default the new code is not running)
  • the PR was tested locally using 1325.7 and 136.8311 with run2_miniAOD_devel modifier added to enable the non-production extras: changes appear only in slimmedJetsAK8 in the jet tag discriminants with only particleNet taggers added while the available ones are unmodified; a "remote" comparison with the same workflow 136.8311 in 11_1_0_pre5 shows fairly similar results in the particleNet tagger values.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 35ce190 into cms-sw:CMSSW_10_2_X Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants