-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNN models for the ParticleNet tagger #26
Conversation
A new Pull Request was created by @hqucms (Huilin Qu) for branch master. @perrotta, @smuzaffar, @mrodozov, @cmsbuild, @slava77, @tulamor can you please review it and eventually sign? Thanks. |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In DeepBoostedJet we have version first, and then full and decorrelated subdirs.
Please adjust the structure, especially if "MD" and non-MD are expected to appear simultaneously
It may be a good time to start populating README.md in the main directory and perhaps also in the subdirs to keep track of the files details.
I would prefer to keep the current structure as in the ParticleNet case, the two versions are not as closely coupled as in the case for DeepAK8 -- The nominal (non-MD) ParticleNet targets Top/W/Z/H tagging, similar to DeepAK8, while ParticleNet-MD is for mass-independent 2-prong tagging (X->bb, X->cc, X->qq) -- This means that we actually might want to update one but not the other.
Good idea! I will add a readme for them. |
is ParticleNet name uniquely identifying the potential uses? |
@slava77 |
sounds good to me. |
Comparison is ready Comparison Summary:
|
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 this appears to be ready to go based on what was seen so far in cms-sw/cmssw#28902 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR adds the MXNet models of the ParticleNet tagger.