Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.2.X][RecoBTag-Combined]DNN models for the ParticleNet tagger #5719

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

smuzaffar
Copy link
Contributor

back ported cms-data/RecoBTag-Combined#26 for 10.2.X. Should be tested with cms-sw/cmssw#29063

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_10_2_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29063
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5535/console Started: 2020/04/04 21:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020

+1
Tested at: 826a811
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-beec7a/5535/summary.html
CMSSW: CMSSW_10_2_X_2020-04-04-1100
SCRAM_ARCH: slc6_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-beec7a/5535/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007544
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007353
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@smuzaffar
Copy link
Contributor Author

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2020

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_10_2_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

@smuzaffar can this PR be merged independently from cms-sw/cmssw#29063 ?

@smuzaffar
Copy link
Contributor Author

@silviodonato , as this conatians modified files ( https://github.com/cms-data/RecoBTag-Combined/pull/29/files) so it should be merged with cms-sw/cmssw#29063.

@slava77
Copy link
Contributor

slava77 commented Apr 8, 2020

the modified files are actually needed to fix the issue which is already in the IBs, it was introduced by #5591
Well, it's also in the files that correspond to taggers that are not running in jenkins tests.

So, I think that this can be merged by itself

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmssw#29063
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5607/console Started: 2020/04/08 19:38

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

+1
Tested at: 826a811
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-beec7a/5607/summary.html
CMSSW: CMSSW_10_2_X_2020-04-08-1100
SCRAM_ARCH: slc6_amd64_gcc700

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-beec7a/5607/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007544
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007352
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@smuzaffar smuzaffar merged commit a9fe653 into IB/CMSSW_10_2_X/gcc700 Apr 9, 2020
@smuzaffar smuzaffar deleted the smuzaffar-patch-1 branch April 9, 2020 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants