Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix to make the HcalCalPedestals run in 74X #10054

Merged
merged 2 commits into from
Jul 31, 2015

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jul 6, 2015

This is needed to make the HCalCalPedestals run in the AlCaReco matrix for 50ns data.
Profiting of this I cleaned also AlCaRecoOutput_cff.py for multiple inclusions of AlcaReco DQM instances.
This is due to non complete backport of #8350 within #9162. @kodolova @bsunanda @diguida you might want to follow this.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2015

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_7_4_X.

Hotfix to make the HcalCalPedestals run in 74X

It involves the following packages:

Configuration/EventContent
Configuration/StandardSequences
EventFilter/HcalRawToDigi

@cmsbuild, @cvuosalo, @franzoni, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor

diguida commented Jul 6, 2015

@mmusich thanks for the careful inspection!

@diguida
Copy link
Contributor

diguida commented Jul 6, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2015

@mmusich
Copy link
Contributor Author

mmusich commented Jul 30, 2015

+1

@mmusich
Copy link
Contributor Author

mmusich commented Jul 30, 2015

@davidlange6 maybe you can find some solution to the issue in https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/1885.html.
I'll need to forwardport it of course (talking about mmusich@54cfd3a)

@davidlange6
Copy link
Contributor

Hi Marco

yes, this is the needed fix. Too bad it wasn’t pushed forward in the first place. would have saved a bunch of work…

Thanks
David

On Jul 30, 2015, at 2:50 PM, Marco Musich notifications@github.com wrote:

@davidlange6 maybe you can find some solution to the issue in https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/1885.html.
I'll need to forwardport it of course...


Reply to this email directly or view it on GitHub.

@mmusich
Copy link
Contributor Author

mmusich commented Jul 30, 2015

@davidlange6 sorry for that, I was waiting some feedback from Hcal DPG.

@bsunanda
Copy link
Contributor

I pushed the changes needed in ALCARECOHcalCalPedestals by doing merge 10054 to CMSSW_7_4_X_2015-07-29-2300 and get from the push command HEAD -> fixHcalPedestals_76X. Shall I sen you the modified file?


From: Marco Musich [notifications@github.com]
Sent: 30 July 2015 15:40
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] Hotfix to make the HcalCalPedestals run in 74X (#10054)

@davidlange6https://github.com/davidlange6 sorry for that, I was waiting some feedback from Hcal DPG.


Reply to this email directly or view it on GitHubhttps://github.com//pull/10054#issuecomment-126328121.

@diguida
Copy link
Contributor

diguida commented Jul 30, 2015

@bsunanda this is already done in #10478 Can you please check your changes w.r.t. that PR?

@bsunanda
Copy link
Contributor

Yes - the changes are in the definition of the last sequence. 10478 has
seqALCARECOHcalCalPedestal = cms.Sequence(hcalCalibPedestal*
hcalDigiAlCaPedestals*
gtDigisAlCaPedestals*
hcalLocalRecoSequencePedestals*
hbherecoPedestals*
hfrecoPedestals*
horecoPedestals)
while there is double usage- so I drop the last 3 and keep
seqALCARECOHcalCalPedestal = cms.Sequence(hcalCalibPedestal*
hcalDigiAlCaPedestals*
gtDigisAlCaPedestals*
hcalLocalRecoSequencePedestals)


From: Salvatore Di Guida [notifications@github.com]
Sent: 30 July 2015 17:35
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] Hotfix to make the HcalCalPedestals run in 74X (#10054)

@bsunandahttps://github.com/bsunanda this is already done in #10478#10478 Can you please check your changes w.r.t. that PR?


Reply to this email directly or view it on GitHubhttps://github.com//pull/10054#issuecomment-126372282.

davidlange6 added a commit that referenced this pull request Jul 31, 2015
Hotfix to make the HcalCalPedestals run in 74X
@davidlange6 davidlange6 merged commit 60a1b89 into cms-sw:CMSSW_7_4_X Jul 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants