-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix to make the HcalCalPedestals run in 74X #10054
Hotfix to make the HcalCalPedestals run in 74X #10054
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_7_4_X. Hotfix to make the HcalCalPedestals run in 74X It involves the following packages: Configuration/EventContent @cmsbuild, @cvuosalo, @franzoni, @davidlange6, @slava77 can you please review it and eventually sign? Thanks. |
@mmusich thanks for the careful inspection! |
please test |
The tests are being triggered in jenkins. |
+1 |
@davidlange6 maybe you can find some solution to the issue in https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/1885.html. |
Hi Marco yes, this is the needed fix. Too bad it wasn’t pushed forward in the first place. would have saved a bunch of work… Thanks
|
@davidlange6 sorry for that, I was waiting some feedback from Hcal DPG. |
I pushed the changes needed in ALCARECOHcalCalPedestals by doing merge 10054 to CMSSW_7_4_X_2015-07-29-2300 and get from the push command HEAD -> fixHcalPedestals_76X. Shall I sen you the modified file? From: Marco Musich [notifications@github.com] @davidlange6https://github.com/davidlange6 sorry for that, I was waiting some feedback from Hcal DPG. — |
Yes - the changes are in the definition of the last sequence. 10478 has From: Salvatore Di Guida [notifications@github.com] @bsunandahttps://github.com/bsunanda this is already done in #10478#10478 Can you please check your changes w.r.t. that PR? — |
Hotfix to make the HcalCalPedestals run in 74X
This is needed to make the HCalCalPedestals run in the AlCaReco matrix for 50ns data.
Profiting of this I cleaned also
AlCaRecoOutput_cff.py
for multiple inclusions of AlcaReco DQM instances.This is due to non complete backport of #8350 within #9162. @kodolova @bsunanda @diguida you might want to follow this.