Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-alca15 Backport the changes for AlCaReco and Trigger codes for Hcal calibrations in PRs 8943, 8950 and 9062 #9162

Merged
merged 1 commit into from
Jun 10, 2015

Conversation

bsunanda
Copy link
Contributor

Modify the AlCa codes, Calibration tree makers and the test scripts. Also changes the offline DQM for the isotrack trigger monitor. Tested in 7_5_X, seen to give clean test on top of 7_4_2.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_7_4_X.

bsunanda:Run2-alca15 Backport the changes for AlCaReco and Trigger codes for Hcal calibrations in PRs 8943, 8950 and 9062

It involves the following packages:

Calibration/HcalAlCaRecoProducers
Calibration/HcalCalibAlgos
Calibration/HcalIsolatedTrackReco
Calibration/IsolatedParticles
DQMOffline/CalibCalo

@diguida, @danduggan, @cerminar, @cmsbuild, @nclopezo, @deguio, @mmusich can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented May 19, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@abdoulline
Copy link

@davidlange6
May we have it merged? It stays idle since quite a while... Thank you

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 10, 2015
bsunanda:Run2-alca15 Backport the changes for AlCaReco and Trigger codes for Hcal calibrations in PRs 8943, 8950 and 9062
@cmsbuild cmsbuild merged commit 97558c2 into cms-sw:CMSSW_7_4_X Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants