Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete fix for HcalCalPedestal AlCaReco (75X) #10507

Merged

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Jul 31, 2015

This is needed to make the HCalCalPedestal producer run in the AlCaReco matrix for data.

Concerning changes of #10054 :

The three commits of the final fix for HcalCalPedestal in #10498 (featuring a fix of the module names in the AlCaReco and the selection of the correct output collections, as well as a test cfg) are cherry-picked.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_5_X.

Complete fix for HcalCalPedestal AlCaReco (75X)

It involves the following packages:

Calibration/HcalAlCaRecoProducers
Configuration/StandardSequences

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor Author

diguida commented Jul 31, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@diguida
Copy link
Contributor Author

diguida commented Jul 31, 2015

@bsunanda @kodolova this is something you might want to watch as well.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2015

@diguida
Copy link
Contributor Author

diguida commented Aug 1, 2015

+1

@davidlange6
Copy link
Contributor

+1

davidlange6 added a commit that referenced this pull request Aug 2, 2015
Complete fix for HcalCalPedestal AlCaReco (75X)
@davidlange6 davidlange6 merged commit efe658a into cms-sw:CMSSW_7_5_X Aug 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants