Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement muon showers so that it is not based on an enum type in the ntuplizer #66

Merged
merged 2 commits into from
Nov 10, 2021

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Nov 5, 2021

PR #62 had a design flaw, namely: it assumed that a shower could only be of 1 type (OneNominal, OneTight, TwoLoose). However, the implementation of the shower object in CMSSW is such that it is possible the shower is of multiple types.

This PR should fix the behavior in the menu tools. It does hand-in-hand with this commit for the ntuples code cms-l1t-offline/cmssw@aefeb23

Copy link
Collaborator

@elfontan elfontan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dildick and Si Xie for the update and checks.
@jheikkil, @arnobaer: let's remember to see if we want to finish to integrate/test the part related to the centrality bits

@elfontan elfontan merged commit 52a11ed into cms-l1-dpg:master Nov 10, 2021
@elfontan
Copy link
Collaborator

Keeping here for reference the workflow to setup the framework in case further tests are needed from the menu team side.

CMSSW SETUP:
cmsrel CMSSW_12_0_2
cd CMSSW_12_0_2/src
cmsenv
git cms-init
git-cms-addpkg L1Trigger/L1TGlobal
git-cms-addpkg L1Trigger/L1TNtuples
git-cms-addpkg DataFormats/L1TGlobal
git-cms-addpkg DataFormats/L1Trigger
git-cms-addpkg DataFormats/L1TMuon
git remote -v
git remote add cmssw_fromSven https://github.com/dildick/cmssw
git remote -v
git fetch cmssw_fromSven
git merge cmssw_fromSven/l1t-integration-CMSSW_12_0_2-uGT-hadronic-shower-trigger
scram b -j 8

==> Add further changes to the L1TNtuples not included in the branch above. Take three modified files from here:
cms-l1t-offline/cmssw@aefeb23

wget https://raw.githubusercontent.com/cms-l1t-offline/cmssw/aefeb23b98ee49bac5adedf61a9739f47d022fe4/L1Trigger/L1TNtuples/src/L1AnalysisL1UpgradeTfMuonShower.cc
wget https://raw.githubusercontent.com/cms-l1t-offline/cmssw/aefeb23b98ee49bac5adedf61a9739f47d022fe4/L1Trigger/L1TNtuples/interface/L1AnalysisL1UpgradeTfMuonShowerDataFormat.h
wget https://raw.githubusercontent.com/cms-l1t-offline/cmssw/aefeb23b98ee49bac5adedf61a9739f47d022fe4/L1Trigger/L1TNtuples/interface/L1AnalysisL1UpgradeDataFormat.h .

MENUTOOLS SETUP (NOTE: logout and then go back to CMSSW_12_0_2/src; no cmsenv):
git clone --depth 1 https://github.com/cms-l1-dpg/L1MenuTools.git
cd L1MenuTools/rate-estimation
wget https://raw.githubusercontent.com/dildick/L1Tutorials/draft-shower-menu-for-run3/tutorials/tme-seed-development/input/L1Menu_Collisions2022_v0_1_1_MuShowers.xml
bash configure.sh L1Menu_Collisions2022_v0_1_1_MuShowers.xml
cmsenv
mkdir -p objs/include
make -j 8

CREATE A COMPATIBLE PS Table:
bash run-ps-generate.sh PrescaleTable-1_L1Menu_Collisions2018_v2_1_0.xlsx L1Menu_Collisions2022_v0_1_1_MuShowers.xml

@dildick dildick changed the title Implement muon showers correctly Implement muon showers so that it is not based on an enum type in the ntuplizer Nov 12, 2021
@elfontan elfontan mentioned this pull request Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants