uGT framework and L1 ntuples for showers in the muon system for Run-3 (HadronicShowerTrigger-8) #36018

dildick · 2021-11-06T01:39:19Z

PR description:

This PR does two things: (1) it builds out the Global Trigger framework for (hadronic) showers in the muon system for Run-3 (2) adds the l1t::MuonShower and l1t::MuonRegionalShower objects to the L1 Ntuples package for rate/efficiency studies.

A new MuonShower object is introduced in the L1TGlobal emulator and data format packages. This object is treated separately from the regular Muon object. Much of it is based on the muon code, but fortunately it's much simpler.
The code is based on UTM lib 0.9.X (https://gitlab.cern.ch/cms-l1t-utm/utm/-/releases/utm_0.9.0), which was recently integrated into CMSSW_12_0_X and CMSSW_12_1_X
- [12.0] Update UTM 0.9.1 cmsdist#7337
- Update UTM to 0.9.1 cmsdist#7281
The uGT for Run-3 will have 4 bits per BX for muon showers: MUS0, MUS1, MUSOOT0 and MUSOOT1. They map to UTM bits MuonShower0, MuonShower1, MuonShowerOutOfTime0 and MuonShowerOutOfTime1
For startup Run-3 we foresee MuonShower0 and MuonShower1 to be used by L1 trigger seeds. The other two bits can be used for enhanced shower triggers.
Previous PRs include
Related PRs include:
A few relevant presentations can be found here:
Related JIRA ticket to include new L1 seeds for Run-3:
- https://its.cern.ch/jira/browse/CMSLITDPG-953
The design, implementation and performance of the hadronic shower trigger is documented here: https://gitlab.cern.ch/tdr/notes/DN-20-033/blob/master/temp/DN-20-033_temp.pdf
Integrating this PR is not urgent, but since it's quite a bit of code, it would be good to get early feedback from CMSSW managers.

PR validation:

Code compiles.
A few integration tests have already been done with Run-3 GEN-SIM-RAW signal samples, such as
/HTo2LongLivedTo4b_MH-1000_MFF-450_CTau-100000mm_TuneCP5_14TeV_pythia8/Run3Winter20DRPremixMiniAOD-110X_mcRun3_2021_realistic_v6-v2/GEN-SIM-RAW
Rate studies are being carried out with this branch uGT emulator code for hadronic shower triggers for Run-3 cms-l1t-offline/cmssw#951 and with official L1 menu tools:
- Draft of muon showers implementation cms-l1-dpg/L1MenuTools#62
- Implement muon showers so that it is not based on an enum type in the ntuplizer cms-l1-dpg/L1MenuTools#66

There should be no changes in any workflow since the showers are not enabled in the global trigger logic.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

cmsbuild · 2021-11-06T01:47:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36018/26467

This PR adds an extra 64KB to repository

cmsbuild · 2021-11-06T01:48:01Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

DataFormats/L1TGlobal (l1)
L1Trigger/L1TGlobal (l1)
L1Trigger/L1TNtuples (l1)

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@kreczko, @rovere, @Martin-Grunewald, @missirol, @thomreis, @dinyar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

dildick · 2021-11-08T16:55:49Z

FYI @giovanni-mocellin

rekovic · 2021-11-09T14:47:11Z

please test

cmsbuild · 2021-11-09T16:01:08Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-897525/20384/summary.html
COMMIT: fa856b3
CMSSW: CMSSW_12_2_X_2021-11-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36018/20384/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 2 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-897525/20384/llvm-analysis/legacy-mod-sa.txt for details.

RelVals

312.0312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO/step2_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO.log
11634.911

----- Begin Fatal Exception 09-Nov-2021 16:19:55 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'EcalBarrelGeometryEPdd4hep' in category 'CMS EDM Framework ParameterSet Description'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

11634.011634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+RecNan+HARVESTRecNan+ALCA/step2_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+RecNan+HARVESTRecNan+ALCA.log

Expand to see more relval errors ...

RelVals-INPUT

136.897136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3/step2_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3.log
138.1138.1_RunCosmics2021+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3/step2_RunCosmics2021+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3.log
138.2138.2_RunCosmics2021+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3/step2_RunCosmics2021+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRuncmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run3_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Tue Nov 9 16:09:49 2021-date Tue Nov 9 16:06:32 2021 s - exit: 256
hlt_mc_GRun

----- Begin Fatal Exception 09-Nov-2021 16:07:04 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_GRun_MC.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_GRun_MC.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 09-Nov-2021 16:09:49 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_GRun_MC.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_GRun_MC.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

dildick · 2021-11-09T16:05:08Z

Lots of failures. I'll have a look if it's always coming from EcalBarrelGeometryEPdd4hep or also from somewhere else

rekovic · 2021-11-10T15:09:07Z

please test

cmsbuild · 2021-11-10T16:24:44Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-897525/20436/summary.html
COMMIT: fa856b3
CMSSW: CMSSW_12_2_X_2021-11-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36018/20436/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 2 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-897525/20436/llvm-analysis/legacy-mod-sa.txt for details.

RelVals

312.0312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO/step2_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO.log
11634.011634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+RecNan+HARVESTRecNan+ALCA/step2_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+RecNan+HARVESTRecNan+ALCA.log
11634.711634.7_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST/step2_TTbar_14TeV+2021_trackingMkFit+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST.log

Expand to see more relval errors ...

RelVals-INPUT

136.897136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3/step2_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3.log
138.1138.1_RunCosmics2021+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3/step2_RunCosmics2021+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3.log
138.2138.2_RunCosmics2021+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3/step2_RunCosmics2021+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRuncmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run3_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Wed Nov 10 16:34:39 2021-date Wed Nov 10 16:31:33 2021 s - exit: 256
hlt_mc_GRun

----- Begin Fatal Exception 10-Nov-2021 16:32:05 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_GRun_MC.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_GRun_MC.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 10-Nov-2021 16:34:39 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_GRun_MC.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_GRun_MC.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

dildick · 2021-11-10T16:27:49Z

@rekovic A parameter for the muon showers is not there apparently. I'll need to fix that.

cmsbuild · 2021-11-10T20:13:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36018/26554

This PR adds an extra 88KB to repository

perrotta · 2021-12-06T10:10:49Z

@cmsbuild please test

cmsbuild · 2021-12-06T13:32:41Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-897525/21007/summary.html
COMMIT: 243dc5a
CMSSW: CMSSW_12_2_X_2021-12-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36018/21007/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 2 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-897525/21007/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3250608
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3250574
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

dildick · 2021-12-06T13:52:18Z

All failures are coming from the messagelogger

dildick · 2021-12-06T13:58:09Z

@rekovic Let me know if you have any more comments or questions.

dildick · 2021-12-06T16:42:41Z

@rekovic Can you sign off, please?

rekovic · 2021-12-07T16:31:18Z

+1

cmsbuild · 2021-12-07T16:31:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-12-08T01:42:59Z

+1

cmsbuild added this to the CMSSW_12_2_X milestone Nov 6, 2021

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-pending labels Nov 6, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 6, 2021

cmsbuild added tests-started and removed tests-pending labels Nov 9, 2021

cmsbuild added tests-rejected and removed tests-started labels Nov 9, 2021

cmsbuild added tests-started and removed tests-rejected labels Nov 10, 2021

cmsbuild added tests-rejected and removed tests-started labels Nov 10, 2021

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Nov 10, 2021

cmsbuild added tests-pending and removed tests-started labels Dec 6, 2021

cmsbuild added tests-started and removed tests-pending labels Dec 6, 2021

cmsbuild added tests-approved and removed tests-started labels Dec 6, 2021

smuzaffar modified the milestones: CMSSW_12_2_X, CMSSW_12_3_X Dec 6, 2021

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Dec 7, 2021

cmsbuild added orp-approved and removed orp-pending labels Dec 8, 2021

cmsbuild merged commit 42fa6b3 into cms-sw:master Dec 8, 2021

dildick deleted the from-CMSSW_12_2_X-ugt-emulator-hadronic-shower-triggers branch December 8, 2021 02:25

qliphy mentioned this pull request Dec 9, 2021

Failure in workflow 139.002 step 3 #36426

Closed

perrotta mentioned this pull request Dec 9, 2021

(Un)packers for hadronic showers at the uGMT input and output #35627

Merged

elfontan mentioned this pull request Feb 23, 2022

Fix of the L1MenuWriter needed for the X2O procedure and update of the L1UpgradeTfMuonShowerTreeProducer cms-l1t-offline/cmssw#987

Closed

This was referenced Aug 27, 2023

add support for L1T-MuonShowers as trigger objects at HLT #36951

Merged

L1T ZDC and uGT Emulator to CMSSW_13_3_X #42634

Merged

makortel mentioned this pull request Sep 5, 2023

higher scrutiny on changes to RAW data formats #42719

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

uGT framework and L1 ntuples for showers in the muon system for Run-3 (HadronicShowerTrigger-8) #36018

uGT framework and L1 ntuples for showers in the muon system for Run-3 (HadronicShowerTrigger-8) #36018

dildick commented Nov 6, 2021 •

edited

Loading

cmsbuild commented Nov 6, 2021

cmsbuild commented Nov 6, 2021

dildick commented Nov 8, 2021

rekovic commented Nov 9, 2021

cmsbuild commented Nov 9, 2021

dildick commented Nov 9, 2021

rekovic commented Nov 10, 2021

cmsbuild commented Nov 10, 2021

dildick commented Nov 10, 2021

cmsbuild commented Nov 10, 2021

perrotta commented Dec 6, 2021

cmsbuild commented Dec 6, 2021

dildick commented Dec 6, 2021

dildick commented Dec 6, 2021

dildick commented Dec 6, 2021

rekovic commented Dec 7, 2021

cmsbuild commented Dec 7, 2021

qliphy commented Dec 8, 2021

uGT framework and L1 ntuples for showers in the muon system for Run-3 (HadronicShowerTrigger-8) #36018

uGT framework and L1 ntuples for showers in the muon system for Run-3 (HadronicShowerTrigger-8) #36018

Conversation

dildick commented Nov 6, 2021 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Nov 6, 2021

cmsbuild commented Nov 6, 2021

dildick commented Nov 8, 2021

rekovic commented Nov 9, 2021

cmsbuild commented Nov 9, 2021

RelVals

RelVals-INPUT

AddOn Tests

dildick commented Nov 9, 2021

rekovic commented Nov 10, 2021

cmsbuild commented Nov 10, 2021

RelVals

RelVals-INPUT

AddOn Tests

dildick commented Nov 10, 2021

cmsbuild commented Nov 10, 2021

perrotta commented Dec 6, 2021

cmsbuild commented Dec 6, 2021

Comparison Summary

dildick commented Dec 6, 2021

dildick commented Dec 6, 2021

dildick commented Dec 6, 2021

rekovic commented Dec 7, 2021

cmsbuild commented Dec 7, 2021

qliphy commented Dec 8, 2021

dildick commented Nov 6, 2021 •

edited

Loading