Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up on PR #62 #65

Closed
dildick opened this issue Nov 4, 2021 · 1 comment
Closed

Follow-up on PR #62 #65

dildick opened this issue Nov 4, 2021 · 1 comment

Comments

@dildick
Copy link
Contributor

dildick commented Nov 4, 2021

I was working with our team to try to get the menu tools to run on signal samples. My initial implementation of shower type may be problematic.

{# Template for signal type conditions like centrality or muon showers #}
{# MuonShowerType from L1TNtuples: kInvalid, kOneNominal,kOneTight, kTwoLoose #}
{# See in: L1Trigger/L1TNtuples/interface/L1AnalysisL1UpgradeDataFormat.h #}

A Regional Muon Shower, or Muon Shower can be (1) nominal or (2) nominal+tight. A tight shower is always also a nominal shower. The enum implementation won't allow that.

@arnobaer Do you have a suggestion how to update the ntuplizer and the menu tools?

@dildick dildick changed the title Follow-up on PR #62 Follow-up on PR https://github.com/cms-l1-dpg/L1MenuTools/pull/62 Nov 4, 2021
@dildick dildick changed the title Follow-up on PR https://github.com/cms-l1-dpg/L1MenuTools/pull/62 Follow-up on PR #62 Nov 4, 2021
@elfontan
Copy link
Collaborator

The final PR for the hadronic muon showers trigger is: #66.
Previous related PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants