-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated files for the v1_1_0 menu for Run 3 (and minor fix for v1_0_0) #11
Conversation
A new Pull Request was created by @elfontan (Elisa Fontanesi) for branch master. @smuzaffar, @epalencia, @aandvalenzuela, @iarspider, @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks. |
please test |
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test TestGeneratorInterfacePythia8InterfaceCompareExternalStreams had ERRORS ---> test testGeneratorInterfacePythia8InterfaceTP had ERRORS Comparison SummarySummary:
|
Pull request #11 was updated. |
Please test |
Hello @smuzaffar, |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01afcf/25361/summary.html Comparison SummarySummary:
|
I guess tests were running on a busy machine as I see error message
anyway, tests are running fine now. By the way, is there any cmssw PR to test these data file changes? |
Thank you @smuzaffar! |
+externals |
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Hello, Thanks a lot in advance, |
An updated full set of xml files for the L1 emulation of prescales and masks coherent with the updated v1_1_0 L1 menu for Run 3 is provided, targeting CMSSW_12_4_0.
The current version of the updated L1 Menu can be found in [1]: L1Menu_Collisions2022_v1_1_0.
NOTE: the current setup of the L1 prescales is still not updated according to the needs for the start of Run 3 given some ongoing discussions to finalize them. For now, the PS table is pretty much the copy of the last 2018 PS table. The update of these files is needed in order to provide a structure of the PS and masks tables fully compatible with the updated menu, so that it is usable for development purposes.
A minor update of the files from the previous PR #9) is also included.
In the context of the trigger studies for the preparation of the Run 3 menu (L1+HLT), we faced an issue related to the emulation of the L1 prescales. Two different issues were found out:
Once that these new files are available here, we will follow-up with the draft PR to update the PrescalesVetosFract_cff.py file: cms-sw/cmssw#38250.
Related github issue for the backport to CMSSW_12_4_0 is #12.
[1]
https://github.com/cms-l1-dpg/L1MenuRun3/tree/master/development/L1Menu_Collisions2022_v1_1_0