Update GlobalBoard class FDL for fractional prescales, to match logic in firmware

[mitaylor]

PR description:

The GlobalBoard class FDL has been updated to match the firmware logic for fractional prescales. This allows the GlobalBoard to produce the correct decision for triggers with fractional prescales, whereas before a fractional prescale would never result in L1A. This update is needed in the context of the L1 menu preparation for Run 3, in order to correctly project the rates for triggers which use fractional prescales.

PR validation:

Basic tests performed successfully starting from CMSSW_12_6_0_pre2.
From CMSSW_12_6_0_pre2/src:

git cms-checkdeps -a -A
scram b -j 8
scram b runtests
scram build code-checks
scram build code-format
runTheMatrix.py -l limited -i all --ibeos

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39464/32192

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mitaylor (Molly Taylor) for master.

It involves the following packages:

• L1Trigger/L1TGlobal (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

After this PR is merged, it should likely be backported to 12_5_X. Is that the plan?

FYI: @elfontan @sanuvarghese @silviodonato @Sam-Harper @mandrenguyen

[missirol]

Small technical suggestions.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39464/32207

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #39464 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

[mitaylor]

After this PR is merged, it should likely be backported to 12_5_X. Is that the plan?

FYI: @elfontan @sanuvarghese @silviodonato @Sam-Harper @mandrenguyen

Backporting to 12_5_X and 12_4_X would be useful.

[mandrenguyen]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-643e8c/27721/summary.html
COMMIT: ad144b4
CMSSW: CMSSW_12_6_X_2022-09-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39464/27721/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Building LCG reflex dict from header file src/L1Trigger/L1TGlobal/src/classes.h
>> Compiling LCG dictionary: tmp/el8_amd64_gcc10/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/a/L1TriggerL1TGlobal_xr.cc
>> Building shared library tmp/el8_amd64_gcc10/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/libL1TriggerL1TGlobal.so
/cvmfs/cms-ib.cern.ch/nweek-02751/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/../lib/gcc/x86_64-redhat-linux-gnu/10.3.0/../../../../x86_64-redhat-linux-gnu/bin/ld: tmp/el8_amd64_gcc10/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/GlobalBoard.cc.o: in function `l1t::GlobalBoard::zeroPrescaleCounters(std::vector > const&)':
GlobalBoard.cc:(.text+0xb9b): undefined reference to `l1t::GlobalBoard::m_precision'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/el8_amd64_gcc10/src/L1Trigger/L1TGlobal/src/L1TriggerL1TGlobal/libL1TriggerL1TGlobal.so] Error 1
Leaving library rule at L1Trigger/L1TGlobal
------- copying files from src/L1Trigger/L1TGlobal/scripts -------
>> copied import_utm.pl
>> Leaving Package L1Trigger/L1TGlobal


[cmsbuild]

Pull request #39464 was updated. @Martin-Grunewald, @rekovic, @epalencia, @cmsbuild, @missirol, @cecilecaillol can you please check and sign again.

[missirol]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-643e8c/28350/summary.html
COMMIT: 058a1ea
CMSSW: CMSSW_12_6_X_2022-10-18-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39464/28350/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• Reco comparison had 6 failed jobs
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3391158
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3391133
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 201 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

I assume the RelVals-INPUT error is unrelated to this PR. I leave it to ORP to decide whether re-running the tests is useful.

[missirol]

Kind ping to @cms-sw/l1-l2 to review this PR.

Once this one is integrated, I'll open a follow-up PR to add the unit test, as agreed with Elisa offline.

[missirol]

Another ping to @cms-sw/l1-l2 to review this PR (L1T had already signed it).

[epalencia]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1

Failures are unrelated, continuing discussion in #39817 for open issue related to confusion about the loop in GlobalBoard.

[rappoccio]

merge