Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated files for the v1_0_0 menu for Run 3 #9

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

elfontan
Copy link
Contributor

@elfontan elfontan commented Apr 3, 2022

An updated full set of xml files for the L1 emulation of prescales and masks coherent with the updated v1_0_0 L1 menu for Run 3 is provided, targeting CMSSW_12_3_0.
The current version of the updated L1 Menu can be found in [1]: L1Menu_Collisions2022_v1_0_0.
(Previous reference PR #8)

In the context of the trigger studies for the preparation of the Run 3 menu (L1+HLT), we recently faced an issue related to the emulation of the L1 prescales. Two different issues were found out:

Once that these new files are available here, we will follow-up with the PR to update the PrescalesVetosFract_cff.py file: cms-sw/cmssw#37453.

[1]
https://github.com/cms-l1-dpg/L1MenuRun3/tree/master/development/L1Menu_Collisions2022_v1_0_0

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2022

A new Pull Request was created by @elfontan (Elisa Fontanesi) for branch master.

@smuzaffar, @epalencia, @iarspider, @cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@cecilecaillol
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8788ed/23635/summary.html
COMMIT: 2be7784
CMSSW: CMSSW_12_4_X_2022-04-03-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-L1TGlobal/9/23635/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8788ed/23635/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8788ed/23635/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3593039
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3592997
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@epalencia
Copy link

+l1

@epalencia
Copy link

@smuzaffar , could you please review?

@smuzaffar
Copy link
Contributor

+externals
@epalencia , this looks good to me. If I understand correctly, this is needed for cms-sw/cmssw#37453 ... right? I already have started the tests for cms-sw/cmssw#37453 . So this data pr can be merged once cms-sw/cmssw#37453 is ready to go in.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@elfontan
Copy link
Contributor Author

elfontan commented Apr 7, 2022

Hi @smuzaffar, yes, correct. These are the "default files" to be used in those config files, that, as we discussed last time, are not used in any standard workflow.
They would be used for the re-emulation of the L1 prescales and masks when applying a dedicated recipe that you can find e.g. here. The specific script that calls those two configuration files containing the new files is hackConditions_cff.py.

I have another question.
I opened the github issue #10 for the backport to CMSSW_12_3_0: do we need this PR merged to proceed there?

@perrotta
Copy link

perrotta commented Apr 7, 2022

@elfontan I notice that besides updating the files, you are also renaming them here with the new Run3 L1 menu name.
Can you confirm that you did check that the previous filenames will not be searched for anywhere else in CMSSW or in the online version of it once the sibling #37453 PR is merged?

@elfontan
Copy link
Contributor Author

elfontan commented Apr 7, 2022

Dear @perrotta,
I "innocently" did it just for additional clarity.
I confirm that I checked that the previous files are not searched for anywhere else in CMSSW except for the two config files updated in PR#37453.
However, I do not even understand what it means "in the online version of it"...
What should I check precisely?

Thanks a lot in advance,
--Elisa

@perrotta
Copy link

perrotta commented Apr 7, 2022

+1

  • tested with #37453

@elfontan
Copy link
Contributor Author

elfontan commented Apr 7, 2022

Thank you!
I opened the related github issue for the backport #10, let me know if it is enough, @smuzaffar.
Cheers,
--Elisa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants