Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#15] Added patch for stuck knobs. #249

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

richardgaunt
Copy link
Collaborator

@richardgaunt richardgaunt commented Jun 17, 2024

Checklist before requesting a review

  • I have formatted the subject to include the issue number
    as [#123] Verb in past tense with a period at the end.
  • I have provided information in the Changed section about WHY something was
    done if this was a bespoke implementation.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run new and existing relevant tests locally with my changes,
    and they have passed.
  • I have provided screenshots, where applicable.

Changed

  1. Knobs with retained values from other stories was fixed in [Hotfix] Seeing knobs from previously selected story  storybookjs/addon-knobs#45 - this PR patches the existing package with this fix.

Screenshots

sb-knob-fix-2024-06-17_15.24.29.mp4

@richardgaunt richardgaunt added the PR: Needs review Pull request needs a review from assigned developers label Jun 17, 2024
Copy link

@github-actions github-actions bot temporarily deployed to pull request June 17, 2024 04:51 Inactive
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.32%. Comparing base (2c45b5b) to head (4c4fdb6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   14.32%   14.32%           
=======================================
  Files          26       26           
  Lines        1243     1243           
  Branches      299      299           
=======================================
  Hits          178      178           
  Misses        855      855           
  Partials      210      210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexSkrypnyk AlexSkrypnyk merged commit bd647ca into main Jun 17, 2024
8 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the 158-fix-stuck-knobs branch June 17, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs review Pull request needs a review from assigned developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants