Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#15] Added patch for stuck knobs. #249

Merged
merged 1 commit into from
Jun 17, 2024
Merged

[#15] Added patch for stuck knobs. #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"lint-fix": "eslint ./components ./.storybook ./webpack --fix && stylelint 'components/**/*.scss' --fix",
"dist": "export NODE_OPTIONS=--openssl-legacy-provider && webpack --config ./webpack/webpack.prod.js",
"dist-dev": "export NODE_OPTIONS=--openssl-legacy-provider && webpack --config ./webpack/webpack.dev.js",
"postinstall": "patch-package",
"test": "npm run test-unit && npm run test-storybook",
"test:ci": "npm run test-unit:ci && npm run test-storybook:ci",
"test-unit": "jest",
Expand All @@ -49,7 +50,7 @@
"@playwright/test": "^1.44.1",
"@storybook/addon-a11y": "^6.5.16",
"@storybook/addon-essentials": "^6.5.16",
"@storybook/addon-knobs": "^6.3.1",
"@storybook/addon-knobs": "^6.4.0",
"@storybook/addon-links": "^6.5.16",
"@storybook/addons": "^6.5.16",
"@storybook/html": "^6.5.16",
Expand Down Expand Up @@ -82,6 +83,7 @@
"lorem-ipsum": "^2.0.8",
"mini-css-extract-plugin": "^1.6.2",
"node-sass-magic-importer": "^5.3.3",
"patch-package": "^8.0.0",
"react": "^17",
"react-dom": "^17",
"sass": "^1.77.5",
Expand Down
12 changes: 12 additions & 0 deletions patches/@storybook+addon-knobs+6.4.0.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
diff --git a/node_modules/@storybook/addon-knobs/dist/registerKnobs.js b/node_modules/@storybook/addon-knobs/dist/registerKnobs.js
index 43b6547..786eacb 100644
--- a/node_modules/@storybook/addon-knobs/dist/registerKnobs.js
+++ b/node_modules/@storybook/addon-knobs/dist/registerKnobs.js
@@ -84,6 +84,7 @@ function resetKnobsAndForceReRender() {
}

function disconnectCallbacks() {
+ knobStore.reset();
var channel = _addons["default"].getChannel();

channel.removeListener(_shared.CHANGE, knobChanged);