[Hotfix] Seeing knobs from previously selected story

[mgameover]

Original issue: #19

Short description:
In Storybook v6.4 disconnectCallbacks is invoked before STORY_CHANGED event has been emitted. As the result the knobs are not being reset.
Fix: reset knobs in disconnectCallbacks function.

[luispied]

LGTM!

[koga73]

I have confirmed that this fixes the issue! When will this be released?

[xenostar]

Is there any intention to merge this?

[koga73]

Is there any intention to merge this?

Not sure I don't think they are maintaining this anymore unfortunately. But I forked and implemented the fix if you want it.
https://www.npmjs.com/package/@koga73/addon-knobs

[literalpie]

@JReinhold To be clear, we discussed this issue in #48, but I did not include this fix in my changes, so I think this is still worth merging/releasing.

Here's a before/after in SB7 if it helps gain confidence.
Before:

After:

[fljot]

@JReinhold any plans to make another release? This wasn't included in 7.0.0 :(

[literalpie]

We should also make dependencies looser before making a new release.

[JReinhold]

sorry folks, something got messed up in the automation flow. This should now be released in 7.0.2, along with the looser dependencies.

https://github.com/storybookjs/addon-knobs/releases/tag/v7.0.2

[fljot]

@mgameover @literalpie
Though fix is generally great and helps, there's still a minor defect in knobs count:

e.g. here it shows 9 from a previous story, but updates to proper value once you use any of knob or toggle addon panel.
Not a biggie, just reporting.

[Terrel007]

@JReinhold Could you please help to release the fix for @storybook/addon-knobs v6.4.0?

[AlexSkrypnyk]

@JReinhold
Some of us are still stuck on v6 of Storybook. Could you please create a 6.4.* release with this patch back ported. Happy to sponsor this work if required. Thank you

[JReinhold]

I no longer maintain this addon. @literalpie has been keeping it afloat, maybe he's interested in backporting, maybe not.

[literalpie]

Hi @AlexSkrypnyk this repo isn't set up to do backporting, but since this is a one-line change you could probably get what you need using patch-package (or the similar tools built in to pnpm and modern yarn).

The change will be on line 87 of node_modules/@storybook/addon-knobs/dist/registerKnobs.js

Hope this helps!