CRM-19016 Order mail processing by contact type to let individuals take precedence #8631
Conversation
| @@ -520,7 +520,8 @@ public function deliver(&$mailer, $testParams = NULL) { | |||
| AND $edTable.id IS null | |||
| AND $ebTable.id IS null | |||
| AND contact_a.is_opt_out = 0 | |||
| $aclWhere"; | |||
| $aclWhere | |||
| ORDER BY $contactTable.contact_type"; | |||
There was a problem hiding this comment.
A solution like
ORDER BY IF($contact.contact_type = 'Individual', 0, 1)
would fit the needs more exactly. But it increases time consumption by factor 10.
There was a problem hiding this comment.
Jenkins test failure seems related. Should be fixed by using the alias(contact_a) instead of $contactTable.
eileenmcnaughton
changed the title
|
Sorry! Used 4.7.6 source code any copied by accident. |
removed whitespace
CRM-19412: Add event ID class to additional participant template
Tweak quicksearch menu style
…emote_api Fix CRM-19408: Create extension.getremote API
Responsive width for dashboard columns
CRM-18157 - Make the mail format required
…or "limit_to/recipient_manual"
Notably, this includes a test with `recipientIsBob`. There other tests mostly a sanity check to ensure that I was writing the test well.
CRM-16876 Ensure that foreign countires are also capitalised when hid…
Fix permission check
InnoDB and MyISAM may have different edge-cases in how the default orderings. However, for deduping, the order is arbitrary. This patch makes the test order-insensitive.
Revert "CRM-19245 - Wrap title and description on manage group page"
CRM-19470 - Notice Fix upon event registration
CRM-19460 - Fix brackets in file uploads
CRM-19486: breaks saved search absolute date
CRM-19179: Set primary location during manual merge
|
@nielosz We're reviewing PRs at the Edale code sprint this week. The relevant part of CRM/Mailing/BAO/MailingJob.php appears to have changed since you submitted your PR, presumably this is why checks are now failing. Are you able to amend your changes to work with the current master code? Apologies on behalf of the community for the delay in reviewing and consequent inconvenience. |
CRM-17917 Fix d8 install requirements
CRM-16189, fix for order api for entity table
CRM-19028 - Change get(userID) to getLoggedInContactID()
…ielosz/civicrm-core Conflicts: CRM/Mailing/BAO/MailingJob.php
|
Messed PR. Will clean tomorrow.... |
CRM-19069 Remove server-hurty OR join
CRM-19482 Localization for participant status counted and no counted …
CRM-19338 - Update doc url location
CRM-19479 - Fix php undefined index notices
CRM-17917 - More fixes for D8 installer
NFC extract function in dedupe process
civicrm#9232) * CRM-19495 Ensure that no dots appear at the bottom of menu links in d8 * Switch to borer: 0 as per suggestion from coleman
CRM-19435: IncludeSmartGroups Option added
CRM-19435: NFC changes
…ielosz/civicrm-core into order-mailings-by-contact-type
|
Updated branch, but PR seems not recognizing it?! |
|
Closed in favour of PR 9236 |
When sending mass mailings some groups may contain organizations and individuals. If a pair of them share the same mail address (let's say »office@school.org«) and deduping is engaged, either the organization or the person will receive the mailing by random. But those emails may differ by token substitutions and thus greeting phrases. The organization would get an impersonal opening like »dear sirs and madams« while the person would get a personal salutation like "Dear Jane Doe". A team like a school's teaching stuff working with a shared email account would know to whom the mail concerns if we could guarantee that the persons get served first.
See Improvement CRM-19016
Although a perfect solution would include a better handling of dýnamicly changing contact type names, I just added a simple order by clause because performance tests with ~200k contacts increased consumed time by factor 10. And "Individual" comes before "Organization" in standard installations.
See line comment.