CRM-18157 - Make the mail format required #9086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @samuelsov Samuel can you please fix the style error found by Jenkins https://test.civicrm.org/job/CiviCRM-Core-PR/11747/checkstyleResult/new/ (making true TRUE) Cheers Seamus |
yashodha
changed the title
|
It should be good... i should definitively have some way to check for checkstyle before submitting the PR |
|
@samuelsov If you download civicrm-buildkit and install it, there is a tool civilint which does the style checking. |
|
The only failing tests seems to be "incomplete tests" (unrelated) and it's really a minor patch. I think there is no much risks in merging this one. |
| @@ -84,7 +84,7 @@ public static function buildQuickForm(&$form) { | |||
| //using for display purpose. | |||
| $form->assign('commPreference', $commPreference); | |||
|
|
|||
| $form->addField('preferred_mail_format', array('entity' => 'contact', 'label' => ts('Email Format'))); | |||
| $form->addField('preferred_mail_format', array('entity' => 'contact', 'label' => ts('Email Format')), TRUE); | |||
There was a problem hiding this comment.
This throws a validation error when attempting to create a new contact from "New Individual" block. Fixed at #9134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. https://issues.civicrm.org/jira/browse/CRM-18157