NFC extract function in dedupe process #9223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
dedupe
branch
2 times, most recently
from
c4f8aa1 to
7f5f887
Compare
JKingsnorth
reviewed
Oct 12, 2016
| // Generate var $migrationInfo. The variable structure is exactly same as | ||
| // $formValues submitted during a UI merge for a pair of contacts. | ||
| $rowsElementsAndInfo = CRM_Dedupe_Merger::getRowsElementsAndInfo($mainId, $otherId, $checkPermissions); | ||
|
|
||
| $migrationInfo = &$rowsElementsAndInfo['migration_info']; |
There was a problem hiding this comment.
I think this line is still required.
There was a problem hiding this comment.
OK - I think I have it right now
eileenmcnaughton
force-pushed
the
dedupe
branch
3 times, most recently
from
f31dbdb to
33e0a48
Compare
eileenmcnaughton
force-pushed
the
dedupe
branch
from
33e0a48 to
e4e1db4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an extraction of the more shared functionality to a separate function to facilitate testing