dev/core#1864 Ensure that when search in trash is not checked that on…

[seamuslee001]

…ly contacts not deleted are returned in the advanced search form

Overview

This is an alternate to #17793 and #17790 in that this aims to focus on the filtering at the Quickform/Query level rather than in the ACL level.

Before

Not selecting search in trash returned contacts in trash

After

Not selecting search in trash only returns contacts not in the trash

Technical Details

We want to allow for the ACLs to allow for anyone who has access to trashed contacts to do a contact.get without having the trash filter applied but we need the form to respect if we are searching in the trash or not. So moving to the query / form layer to do this. I have also added a unit test to check on if we are searching in the trash that the correct where clause is added

ping @eileenmcnaughton @spalmstr @colemanw @demeritcowboy

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Thanks @seamuslee001 str_replace is still a bad spell - but less whiffy than before!

[eileenmcnaughton]

I should note it's really a where clause not a permission clause - anyway...

[eileenmcnaughton]

I just tested this & it works - we should port to 5.27 & drop a release inn the next day or 2 (@totten )

[colemanw]

Thanks for working on this @seamuslee001

[demeritcowboy]

Thanks also for doing this!

[agileware-justin]

Thanks for fixing this bug @seamuslee001 and others much appreciated!

[spalmstr]

@seamuslee001 My thanks, too.

[eileenmcnaughton]

Note we are hoping to get @totten to drop a release in the next day or 2 with this.

[totten]

Note: The 5.27-stable backport of this is a little hard to see due to some crossed wires. The net effect of #17796+#17802 is to backport #17798.