Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression whereby deleted contacts are in quicksearch results #18213

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 21, 2020

Overview

Fixes a recent regression (5.27?) where deleted contacts returned in quicksearch results

As with #17798 it regressed in 5.27 but was not picked up until today

Before

Quicksearch results include deleted contacts

After

Contacts excluded

Technical Details

Note that there are several other tests on this function around the added test. I slightly cleaned up the building of $where

Comments

@civibot
Copy link

civibot bot commented Aug 21, 2020

(Standard links)

@seamuslee001
Copy link
Contributor

Looks good to me

@seamuslee001 seamuslee001 merged commit 5fbba0e into civicrm:5.29 Aug 21, 2020
@seamuslee001 seamuslee001 deleted the is_deleted branch August 21, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants