Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#1864 Revert changes to ACL test and ACL API class and update… #17802

Merged
merged 1 commit into from
Jul 13, 2020
Merged

dev/core#1864 Revert changes to ACL test and ACL API class and update… #17802

merged 1 commit into from
Jul 13, 2020

Conversation

seamuslee001
Copy link
Contributor

@civibot
Copy link

civibot bot commented Jul 13, 2020

(Standard links)

@civibot civibot bot added the 5.27 label Jul 13, 2020
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 isn't that the same as the one I merged #17796

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton nope that one had the changes in the API Class and also commented out the ACL unit tests which my 5.28 one didn't

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 so this reverts the one I merged & re-fixes ? #17796 - I'm getting confused

@eileenmcnaughton
Copy link
Contributor

OK - you are on it - I am not

@seamuslee001
Copy link
Contributor Author

it reverts what isn't merged into 5.28 and applies what needs to to fix the problem

@eileenmcnaughton
Copy link
Contributor

That old chestnut

@seamuslee001
Copy link
Contributor Author

Test fail expected and unrelated

@seamuslee001 seamuslee001 merged commit b5919da into civicrm:5.27 Jul 13, 2020
@totten totten mentioned this pull request Jul 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.27 merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seamuslee001 @eileenmcnaughton