Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused/unneeded pseudoconstant functions #16771

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Mar 13, 2020

Overview

Many years ago we started restructuring our pseudoconstant classes to move away from individual functions like these. Eventually we'll remove them all.

Before

1 unused function and 2 barely used.

After

Marked deprecated for future removal.

@civibot
Copy link

civibot bot commented Mar 13, 2020

(Standard links)

@civibot civibot bot added the master label Mar 13, 2020
@colemanw
Copy link
Member Author

@twomice can you review this one?

@eileenmcnaughton
Copy link
Contributor

@colemanw I took a look at this but I struggled off the bat to very the pcp changes so I did a test & dug into the function - which gives this (bigger) alternative change #16790

@colemanw
Copy link
Member Author

@eileenmcnaughton I've rebased this with your changes

@colemanw colemanw changed the title [REF] Remove unused/unneeded pseudoconstant functions Remove unused/unneeded pseudoconstant functions Mar 17, 2020
@eileenmcnaughton
Copy link
Contributor

@colemanw I'm OK with the change & agree the functions are not called from core -however, I think we should stick in deprecation notices rather than remove the - the alternative is more work to ensure these functions are not called in extensions

@colemanw colemanw changed the title Remove unused/unneeded pseudoconstant functions Deprecate unused/unneeded pseudoconstant functions Mar 18, 2020
@colemanw
Copy link
Member Author

Ok @eileenmcnaughton I've switched this from remove to deprecate

@eileenmcnaughton eileenmcnaughton merged commit e6afea1 into civicrm:master Mar 18, 2020
@eileenmcnaughton eileenmcnaughton deleted the pcp branch March 18, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants