[REF] Use ?? operator instead of CRM_Utils_Array::value() in return statements

[colemanw]

Overview

This is part of a series of PRs to update an old code pattern. CRM_Utils_Array::value() can in many cases be swapped for the new PHP7 ?? operator.

Comments

This PR was generated from a single regex which replaces all return statements that use CRM_Utils_Array::value() with only 2 arguments. Before/after are functionally identical because the default is null.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

All of these look good. And especially for these ones it seems better that it would now throw an error if the thing is an object.

[colemanw]

@twomice this is the only return-by-ref function affected by this PR. I'll do a followup to remove the & from the function declaration per your comment.

[colemanw]

Turns out the function was unused. #16771