[REF] Fix PCP getPcpDashboardInfo to be tested & use sensible functions #16790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code cleanup to use our preferred functions & avoid bad practices like $$component
Before
Use of deprecated calls to get keys & labels, hard to read due to $$component
After
Uses preferred methods $$component replaced by a function
Technical Details
Alternative to #16771
Comments
I removed a parent-blocking tearDown - not too sure what the implications will be for the tests - might be some fails to clean up