Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fix PCP getPcpDashboardInfo to be tested & use sensible functions #16790

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Mar 16, 2020

Overview

Code cleanup to use our preferred functions & avoid bad practices like $$component

Before

Use of deprecated calls to get keys & labels, hard to read due to $$component

After

Uses preferred methods $$component replaced by a function

Technical Details

Alternative to #16771

Comments

I removed a parent-blocking tearDown - not too sure what the implications will be for the tests - might be some fails to clean up

@civibot
Copy link

civibot bot commented Mar 16, 2020

(Standard links)

@civibot civibot bot added the master label Mar 16, 2020
@eileenmcnaughton eileenmcnaughton changed the title Fix PCP getPcpDashboardInfo to be tested & use sensible functions [REF] Fix PCP getPcpDashboardInfo to be tested & use sensible functions Mar 16, 2020
@colemanw
Copy link
Member

Looks good to me. Thanks for adding tests.

@colemanw
Copy link
Member

@eileenmcnaughton test fail relates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants