dev/core#1339 Dedupe screen check to carry across any data where the other contact has none by default. #15595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
dedupe3
branch
from
a1d34b7
to
84ac4dc
Compare
…other contact has none by default. This change in default means that if the contact to be deleted has data in a field and the contact to be kept does not the checkbox loads as checked by default (so it's easier to keep too much data but harder to lose some.) https://lab.civicrm.org/dev/core/issues/1339 The user can override by unchecking - this is just what is set on screen load
eileenmcnaughton
force-pushed
the
dedupe3
branch
from
84ac4dc
to
3d1d395
Compare
|
I've rebased |
|
@eileenmcnaughton looks great and helpful for users in the merge process. I've tested this and confirm that this works fine in loading the checkbox as enabled on page load. Few things that I've noticed -
Do we really need to worry about these fields? |
|
I haven't checked the code, but I've checked in with our database admin team here who think this would be a good and potentially time-saving improvement. |
|
@jitendrapurohit I understand your review as 'this is good - it would be good to do a follow up that takes it further' |
|
yes @eileenmcnaughton As it is not affecting the existing functionality. I think it is good to merge this. Other fields could be added in a follow-up pr. |
|
Merging based on the reviews of Jon and Jitendra |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jan 7, 2020
…ould otherwise be lost Full details are here civicrm#15595 - although this does not include the cleanup commits I did getting to this point. Bug: T235450 Change-Id: I60d93df0ee3d34ff5c3b7b7c7e5034aafbdfd740
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jan 9, 2020
in the other contact's field This partially addresses reviewer feedback about the limitations of civicrm#15595
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Jan 9, 2020
in the other contact's field This partially addresses reviewer feedback about the limitations of civicrm#15595
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change in default means that if the contact to be deleted has data in a field and the contact to be kept does not the checkbox loads as checked by default (so it's easier to keep too much data but harder to lose some.)
The user can override by unchecking - this is just what is set by default on screen load
Before
After
Technical Details
Change is superficial to the form presentation
I did some cleanup getting to where I could decide the code change. I can rebase out when merged #15594
Comments