[REF] minor refactor towards removing complexity. #15594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change actually makes the foreach & if following it redundant. I left them out for legibility but basically all the wrangling is on the 'other' contact. We do just one thing with the 'main' contact so the whole foreach & if is silly. Will follow up with removal of those
|
(Standard links)
|
colemanw
reviewed
Oct 24, 2019
| $value[1] = NULL; | ||
| } | ||
| $rows["move_$field"]['main'] = self::getFieldValueAndLabel($field, $main)['label']; | ||
| $rows["move_$field"]['other'] = self::getFieldValueAndLabel($field, $other)['label']; |
There was a problem hiding this comment.
The function getFieldValueAndLabel does not appear to return an indexed array, so I don't think you can access ['label'] from its return values.
There was a problem hiding this comment.
Oh nevermind I see you changed that in this pr.
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code legibility improvement.
Before
Less readable
After
More readable.
UI still works the same
Technical Details
This change actually makes the foreach & if following it redundant. I left them out for legibility
but basically all the wrangling is on the 'other' contact. We do just one thing with the 'main'
contact so the whole foreach & if is silly. This is the follow up to #15593 that incorporates removal of the if & foreach
Comments