Check field to carry over custom data by default when the other contact has none

[eileenmcnaughton]

Overview

This alter's the defaults on the contact merge screen to check the checkbox for carrying over custom data by default when the contact to be deleted has a value in a custom field and the other contact does not.

This partially addresses reviewer feedback about the limitations of #15595

Before

After

Technical Details

Note reviewer feedback touched on some other fields too - I've left them out of scope for now.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[ejegg]

Tested and working locally. Pretty funky looking array, though I guess getting around that would be a bigger change!

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass
  • (r-doc) Pass
  • (r-run) Pass tested this and confirmed the updated behaviour is correct and sensible.
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Pass