[REF] Activity Summary report - move temp table generation etc from postProcess to buildQuery, remove postProcess, don't skip in unit tests

[davejenx]

Overview

Refactor Activity Summary report to a more standard structure so that it no longer needs to be skipped in unit tests.

Before

Activity Summary report has to be skipped in unit tests.
ReportTemplateTest.php gives:

OK, but incomplete, skipped, or risky tests!
Tests: 213, Assertions: 1245, Incomplete: 11.

After

Activity Summary report is not skipped in unit tests and tests pass.
ReportTemplateTest.php gives:

OK, but incomplete, skipped, or risky tests!
Tests: 214, Assertions: 1252, Incomplete: 8.

Technical Details

Refactor CRM/Report/Form/ActivitySummary.php, removing postProcess(), moving temp table creation etc into buildQuery(). In tests/phpunit/api/v3/ReportTemplateTest.php, remove activitySummary from reportsToSkip, as tests pass after this refactoring; also rename testActivitySummary() to testActivityDetails(), as it actually tests report_id = Activity which is the activity details report.

This PR builds on @eileenmcnaughton's refactoring in #14364.
It is work towards improving unit tests for activity summary, which is needed for #13540 to be merged.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[davejenx]

I used git scan am to grab #14364 as a new branch, then created my feature branch from there, which has resulted in Eileen's commit from that PR being listed in this one. Let me know if that needs doing differently.

[davejenx]

I tested the report before vs after on various queries including as an ACL'd user and did not see any differences. The report is pretty buggy and the results were wrong in some cases, so if you see incorrect results while testing, please check both with & without the PR! At least now we can get some better test coverage and pin down the problems.

[eileenmcnaughton]

Thanks @davejenx - it seems to be equally buggy before & after - which oddly is the goal here! Oddly I note that the duration field that causes so much complexity & code in this report actually doesn't work properly (before or after) & it's blank if you turn off group by - likely paging is broken too.

At least now we can get some better test coverage and pin down the problems.

YES - we have done the pre-requisite for improving this report