Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Activity Summary report - stop overloading from function on activity summary report #14364

Closed
wants to merge 1 commit into from

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Minor cleanup

Before

Function called twice to do 2 different disparate things

After

Separate functions

Technical Details

Comments

@civibot
Copy link

civibot bot commented May 28, 2019

(Standard links)

@davejenx
Copy link
Contributor

This looks good to me. Sensible refactoring and gives the same results as before on a few test runs. (Those results are wrong in a few respects but that's for another PR, this one leaves the results unchanged as expected.)

@eileenmcnaughton
Copy link
Contributor Author

incorporated elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants