Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Activity Summary report - move temp table generation etc from postProcess to buildQuery, remove postProcess, don't skip in unit tests #14375

Merged
merged 2 commits into from
May 29, 2019
Merged

[REF] Activity Summary report - move temp table generation etc from postProcess to buildQuery, remove postProcess, don't skip in unit tests #14375

merged 2 commits into from
May 29, 2019

Commits on May 29, 2019

  1. Activity Summary report - stop overloading from function on activity … 

    …summary report
    @eileenmcnaughton @davejenx
    eileenmcnaughton authored and davejenx committed May 29, 2019
    Configuration menu
    Copy the full SHA
    1ad3437 View commit details
    Browse the repository at this point in the history

  2. Refactor CRM/Report/Form/ActivitySummary.php, removing postProcess(),… 

    … moving temp table creation etc into buildQuery(). In tests/phpunit/api/v3/ReportTemplateTest.php, remove activitySummary from reportsToSkip, as tests pass after this refactoring; also rename testActivitySummary() to testActivityDetails(), as it actually tests report_id = Activity which is the activity details report.
    @davejenx
    davejenx committed May 29, 2019
    Configuration menu
    Copy the full SHA
    d5625bc View commit details
    Browse the repository at this point in the history