Prev next #13533
Merged
Prev next #13533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug as described was a bit tricksy to replicate as it is inconsistent and the code is not actually outputting the tags/ groups. I think these are pre-existing issues I was able to replicate by having 2 search profiles - one with only tags & one one with only groups & switching back & and force on output - once I replicated I found that there was a regression due to 2ca46d4#diff-e54381bfdf51e31cab376c71ca0d66ffR4967 whereby the groupBy had been dropped, causing the results to be squashed into a single row
|
(Standard links)
|
|
The change looks fine to me, i'm just going to go through a quick r-run now |
|
I have done an r-run and can't see any issues with this PR. adding merge on pass |
This prevents an error when using the cache and allows us to move past this without untangling the messy way other tables are joined back in for now. Note it became necessary due to query changes off the cache but the query is no different in accuracy
|
We hit a full group by bug :-( - I've extended the cases where fgb is disabled to cope |
|
unrelated fails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix search regressions introduced in 5.9 relating to caching & custom searches
Before
Under some circumstances searches which output tags or groups present all contacts in a single row
After
Correct number of rows returned
Technical Details
This arises because 'GROUP_CONCAT' is used without the GROUP BY clause due to
eileenmcnaughton@2ca46d4#diff-e54381bfdf51e31cab376c71ca0d66ffR4967
There is some somewhat unrelated bugginess about the inclusion of groups & tags that makes this hard to replicate :-(
Comments
I have also pulled in #13531 which I think is a related regression & should also go into the rc