Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#695 - Make custom searches slightly less fragile #13531

Closed
wants to merge 1 commit into from

Conversation

aydun
Copy link
Contributor

@aydun aydun commented Feb 4, 2019

Overview

See description in https://lab.civicrm.org/dev/core/issues/695

Before

A custom search where contactIDs() returns contact_a.id AS contact_id does not populate the prevnext cache resulting in result selections not being saved. But contact_a.id as contact_id works - ie case sensitive.

After

contact_a.id AS contact_id and contact_a.id as contact_id both work

@civibot
Copy link

civibot bot commented Feb 4, 2019

(Standard links)

@civibot civibot bot added the master label Feb 4, 2019
@eileenmcnaughton
Copy link
Contributor

@totten ping - this seems fine to merge but I just want to draw it to your attention

@eileenmcnaughton
Copy link
Contributor

actually @aydun I think we should add this into the 5.10 rc

@eileenmcnaughton eileenmcnaughton mentioned this pull request Feb 5, 2019
@eileenmcnaughton
Copy link
Contributor

@aydun I merged this via 5.10 rc so it's already merged & I'm closing this #13535

@aydun
Copy link
Contributor Author

aydun commented Feb 5, 2019

Even better - thanks @eileenmcnaughton

@aydun aydun deleted the core_695_prevnext_cs branch March 7, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants