dev/core#695 - Make custom searches slightly less fragile #13531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
See description in https://lab.civicrm.org/dev/core/issues/695
Before
A custom search where
contactIDs()
returnscontact_a.id AS contact_id
does not populate the prevnext cache resulting in result selections not being saved. Butcontact_a.id as contact_id
works - ie case sensitive.After
contact_a.id AS contact_id
andcontact_a.id as contact_id
both work